Default Privilege Definitions Updating

  • What triggers updating /etc/inc/ (pfSense/tools/scripts/generate-privdefs.php).  Recent metadata changes to /usr/local/www/services_rfc2136_edit.php don't seem to be getting picked up.

  • Rebel Alliance Developer Netgate

    It's a script we have to run manually from the source repo, tools/scripts/generate-privdefs.php

    I ran it and it picked up the change, just pushed it. Thanks!

  • Thanks Jim.

    So I take it then there is not additional action or process I/we should take when making privileges metadata changes.  That correct?

  • Rebel Alliance Developer Netgate

    Not usually.

    You can run that script and if the diff looks sane (just your own update), submit that as a PR as well, perhaps the same PR as the other change, but it's something we usually run before each release anyhow to make sure things are caught up.

    Sometimes that file gets inadvertently hand-edited and the diffs make less sense so they need manual review, but at the moment things are quite good there. Running the script produced only a one-line diff.

Log in to reply