Tinc on 2.3 Error & Crash

Mr. Jingles

But to install the package… "sudo apt-get install" is near a minor detail of everyday work of anyone related to networks or such...

I've been installing ports for decades like this. Yesterday I did:

sudo apt-get install facebook

And that is now neatly running on my pfSense 2.6.8. Amazing environment, OS/2.

Microsoft should get very afraid.

Vetal

@Mr.:

@Vetal:

But to install the package… "sudo apt-get install" is near a minor detail of everyday work of anyone related to networks or such...

I've been installing ports for decades like this. Yesterday I did:
sudo apt-get install facebook
And that is now neatly running on my pfSense 2.6.8. Amazing environment, OS/2.

Microsoft should get very afraid.

Wow, how that smart! Really, can impress 13 y.o. on geeks party.
Do you think I will try to justify to prove anything for the folks who ready to start class on Debian vs BSD package management to show their smart a**?

"Install a package", that's my point, get better/bigger point next time, my boring friend.

yodaphone

@doktornotor:

@yodaphone:

In tinc tab i have this

IPv4* * * * * * NONE

Hooray. So, when you remove that rule, the error is gone, correct?

If you create another interface group, and use test for Group Name, and add the same rule there, do you get an error like macro 'test' not defined ?

Remove it, create another interface group, and use prefix-test for Group Name and add the same rule there, do you get an error like macro 'prefix' not defined ?

ok rebuilt the machine with what you asked for. here are the screen shots, logs & crash report.

Install Log for tinc (I did this thro the GUI - Package Manager. no hack shit)

Installing pfSense-pkg-tinc…
Updating pfSense-core repository catalogue...
pfSense-core repository is up-to-date.
Updating pfSense repository catalogue...
pfSense repository is up-to-date.
All repositories are up-to-date.
The following 2 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
pfSense-pkg-tinc: 1.0.28 [pfSense]
tinc: 1.0.29 [pfSense]

Number of packages to be installed: 2

119 KiB to be downloaded.
Fetching pfSense-pkg-tinc-1.0.28.txz: . done
Fetching tinc-1.0.29.txz: …....... done
Checking integrity... done (0 conflicting)
[1/2] Installing tinc-1.0.29…
[1/2] Extracting tinc-1.0.29: …..... done
[2/2] Installing pfSense-pkg-tinc-1.0.28…
[2/2] Extracting pfSense-pkg-tinc-1.0.28: …...... done
Saving updated package information...
done.
Loading package configuration... done.
Configuring package components...
Loading package instructions...
Custom commands...
Executing custom_php_install_command()...done.
Executing custom_php_resync_config_command()...done.
Menu items... done.
Services... done.
Writing configuration... done.

Cleaning up cache... done.
Success

it installed with an Interface group called pkg-tinc. I set up tinc with another host & put rule to allow tcp/udp. it didnt work. same error as before.

so i deleted that group & created a new group called prefix-test & setup the rules. it created a crash report. please see below

Also got the error message

There were error(s) loading the rules: /tmp/rules.debug:149: macro 'prefix' not defined - The line in question reads [149]: pass in quick on $prefix-test inet from any to any tracker 1485799084 keep state label "USER_RULE"
@ 2017-01-30 17:58:07

Crash report begins. Anonymous machine information:

amd64
10.3-RELEASE-p15
FreeBSD 10.3-RELEASE-p15 #466 583cd4646(RELENG_2_3): Mon Jan 30 07:12:16 CST 2017 root@ce23-amd64-builder:/builder/pfsense/tmp/obj/builder/pfsense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[30-Jan-2017 17:37:16 Etc/UTC] PHP Warning: rename(/usr/local/etc/tinc,/usr/local/etc/tinc.old): Directory not empty in /usr/local/pkg/tinc.inc on line 33
[30-Jan-2017 17:37:16 Etc/UTC] PHP Stack trace:
[30-Jan-2017 17:37:16 Etc/UTC] PHP 1. {main}() /etc/rc.start_packages:0
[30-Jan-2017 17:37:16 Etc/UTC] PHP 2. sync_package() /etc/rc.start_packages:90
[30-Jan-2017 17:37:16 Etc/UTC] PHP 3. eval() /etc/inc/pkg-utils.inc:631
[30-Jan-2017 17:37:16 Etc/UTC] PHP 4. tinc_save() /etc/inc/pkg-utils.inc(631) : eval()'d code:1
[30-Jan-2017 17:37:16 Etc/UTC] PHP 5. rename() /usr/local/pkg/tinc.inc:33
[30-Jan-2017 17:38:07 Etc/UTC] PHP Warning: rename(/usr/local/etc/tinc,/usr/local/etc/tinc.old): Directory not empty in /usr/local/pkg/tinc.inc on line 33
[30-Jan-2017 17:38:07 Etc/UTC] PHP Stack trace:
[30-Jan-2017 17:38:07 Etc/UTC] PHP 1. {main}() /usr/local/www/pkg_edit.php:0
[30-Jan-2017 17:38:07 Etc/UTC] PHP 2. eval() /usr/local/www/pkg_edit.php:253
[30-Jan-2017 17:38:07 Etc/UTC] PHP 3. tinc_save() /usr/local/www/pkg_edit.php(253) : eval()'d code:1
[30-Jan-2017 17:38:07 Etc/UTC] PHP 4. rename() /usr/local/pkg/tinc.inc:33

Filename: /var/crash/minfree
2048

this is a fresh install. I DID NOT DO ANYTHING FANCY HERE

doktornotor

@yodaphone:

it installed with an Interface group called pkg-tinc. I set up tinc with another host & put rule to allow tcp/udp. it didnt work. same error as before.
so i deleted that group & created a new group called prefix-test & setup the rules. it created a crash report. please see below

Also got the error message

There were error(s) loading the rules: /tmp/rules.debug:149: macro 'prefix' not defined - The line in question reads [149]: pass in quick on $prefix-test inet from any to any tracker 1485799084 keep state label "USER_RULE"
@ 2017-01-30 17:58:07

Thank you very much. Finally! Confirms that the issue is not with the package at all. It's the pfSense code in behind that does not handle interface group names like this (just recently made possible on 2.3.3+ in order to reserve pkg- prefix for packages that make use of interface groups, otherwise it wouldn't let you save such things.)

https://redmine.pfsense.org/issues/7173

yodaphone

@doktornotor:

Thank you very much. Finally! Confirms that the issue is not with the package at all. It's the pfSense code in behind that does not handle interface group names like this (just recently made possible on 2.3.3+ in order to reserve pkg- prefix for packages that make use of interface groups, otherwise it wouldn't let you save such things.)

https://redmine.pfsense.org/issues/7173

Did one more thing. uninstalled tinc. reinstalled again with defaults. a pkg-tinc group is created. & when i try to use rules & start it up i get this error again

There were error(s) loading the rules: /tmp/rules.debug:149: macro 'pkg' not defined - The line in question reads [149]: pass in quick on $pkg-tinc inet from any to any tracker 1485800525 keep state label "USER_RULE"
@ 2017-01-30 18:22:08

So went & deleted it. created an interface group called doktornotor :o 8) & setup rules again

No error but no traffic is going thro

doktornotor

Needs to be fixed in pfSense itself, as noted on the bug.

P.S. PR for the rename() quirk here: https://github.com/pfsense/FreeBSD-ports/pull/275 (but that is NOT what's breaking the package).

yodaphone

thanks… will keep this test setup. let me know if you want me to test something.

Mr. Jingles

@Vetal:

@Mr.:
@Vetal:

But to install the package… "sudo apt-get install" is near a minor detail of everyday work of anyone related to networks or such...

I've been installing ports for decades like this. Yesterday I did:
sudo apt-get install facebook
And that is now neatly running on my pfSense 2.6.8. Amazing environment, OS/2.

Microsoft should get very afraid.
Wow, how that smart! Really, can impress 13 y.o. on geeks party.
Do you think I will try to justify to prove anything for the folks who ready to start class on Debian vs BSD package management to show their smart a**?

"Install a package", that's my point, get better/bigger point next time, my boring friend.

Friend is a title I reserve for people I like.