Playing with fq_codel in 2.4

mattund

I feel like that should work; I personally ended up doing floating rules on the WAN interfaces I need to shape (I have a cable/DSL setup). Now, given you have your shaping set to 900/900, maybe you need to increase the slot size/queue length? That's a pretty fast connection. Then again a while ago I think I refuted this and said that queue sizes literally don't matter... the internal behavior of this scheduler as it is on FreeBSD is not well documented, there are some research papers by a particular organization but besides that there's not much else.

Generally seeing drops is actually OK, perhaps even good, because FQ_CoDel should be favoring dropping some traffic over allowing it to sit in queue for a while; in my experience FQ_CoDel is a very "all or nothing" algorithm. This doesn't explain your F's though. I find it odd you're getting that while also seeing activity on the queues. Has to be some sort of parameter issue...

Here is my ipfw sched show:

00001: 128.000 Mbit/s    0 ms burst 0
q65537  50 sl. 0 flows (1 buckets) sched 1 weight 0 lmax 0 pri 0 droptail
 sched 1 type FQ_CODEL flags 0x0 0 buckets 0 active
 FQ_CODEL target 5ms interval 100ms quantum 1514 limit 10240 flows 1024 NoECN
   Children flowsets: 1
00002:  11.128 Mbit/s    0 ms burst 0
q65538  50 sl. 0 flows (1 buckets) sched 2 weight 0 lmax 0 pri 0 droptail
 sched 2 type FQ_CODEL flags 0x0 0 buckets 0 active
 FQ_CODEL target 5ms interval 10ms quantum 1514 limit 10240 flows 1024 NoECN
   Children flowsets: 2
00003:  25.000 Mbit/s    0 ms burst 0
q65539  50 sl. 0 flows (1 buckets) sched 3 weight 0 lmax 0 pri 0 droptail
 sched 3 type FQ_CODEL flags 0x0 0 buckets 0 active
 FQ_CODEL target 10ms interval 100ms quantum 1514 limit 10240 flows 1024 NoECN
   Children flowsets: 3
00004:   2.000 Mbit/s    0 ms burst 0
q65540  50 sl. 0 flows (1 buckets) sched 4 weight 0 lmax 0 pri 0 droptail
 sched 4 type FQ_CODEL flags 0x0 0 buckets 0 active
 FQ_CODEL target 5ms interval 100ms quantum 1514 limit 10240 flows 1024 NoECN
   Children flowsets: 4

1 - Cable download
2 - Cable upload
3 - DSL download
4 - DSL upload

mattund

@w0w Do we have a redmine number? I can help out; I don't see any PR's yet to fix this

get_single_sysctl("net.inet.ip.dummynet.codel.target")

I call this because the script needs to pull in the default values for several of the algorithms and I didn't want to hard-code it.

My first impression is this is returning something funky. Anyone's new VMs result of sysctl -a | grep net.inet.ip.dummynet.codel.target showing as empty or a non-numeric value? I get net.inet.ip.dummynet.codel.target: 5000

Or, they changed or renamed get_single_sysctl

It's those items or something with my PHP that is screwy in a recent change; I actually don't do PHP very often so this is likely...

Thinking this out, it may be that without the dummynet kernel module loaded (or something like that) there is no sysctl ready for the script to use. Maybe I need to load the kernel module first before I start trying to get these values. I bet you it's not loaded at the very first execution of the script.

If this is the case, /sbin/kldload dummynet in the command line or in the UI's command executor should fix this.

zwck

Would you mind screenshotting
/ creating a catch one and all floating rule? I am not sure how I am supposed to set this up.

mattund

@zwck https://forum.netgate.com/post/772130

I posted that earlier for reference, I am still using that configuration I believe

zwck

@mattund perfect I'll give that a try. Thank you so much

w0w

@mattund
No I did not created any redmine issues.

zwck

@mattund said in Playing with fq_codel in 2.4:

Now, given you have your shaping set to 900/900, maybe you need to increase the slot size/queue length? That's a pretty fast connection.

Hey Matti,

in the mean time i switched to a floating rule setup, and the rule pretty much catches all similarly to what you described. I also played with bucket size and queue length to no avail, when i download or upload most of the time the scheduler uses sub 15 buckets and the default is 256 or so. I doubled the limit as well to 20480 and flows up to 2048 there was no difference. Then i read the fq_codel manual and the standard values put in place to cover basically everything from 1mbit to 1000mbit. Maybe the drop i see is just what i have.

Thanks for your help.

Dazog

I am getting these errors in 2.4.4

kernel config_aqm Unable to configure flowset, flowset busy!

Anyone else seeing these?

blinde

@mattund said in Playing with fq_codel in 2.4:

@slowgrind said in Playing with fq_codel in 2.4:

So after applying the patch do you just fill in the settings under limiters?

Here's what I'm doing. This might be a little more than what you need, but I figure I would share my configuration in case others have a crazy Multi-WAN multi-LAN setup like I do. I've constructed a series of limiters, one for download and one for upload, each with its own associated queue (you can make the queue with the "+ Add new Queue" button on the bottom of a Limiter's settings page) :

(I have more for my second ISP following that naming scheme: lINTERFACEDownload/lINTERFACEUpload and qINTRERFACEDownload/qINTERFACEUpload children)

I'm assigning FQ_CoDel to the scheduler on the parent limiter and leaving everything else alone. You can either edit the parameters, or leave them at default if you have a typical connection (FQ_CoDel is supposed to be "knobless" after all).

According to the following diagram, this is how the traffic will flow inside dummynet:
			    (flow_mask|sched_mask)  sched_mask
		    +---------+	  weight Wx  +-------------+
		    |	      |->-[flow]-->--|		   |-+
	       -->--| QUEUE x |	  ...	     |		   | |
		    |	      |->-[flow]-->--| SCHEDuler N | |
		    +---------+		     |		   | |
			...		     |		   +--[LINK N]-->--
		    +---------+	  weight Wy  |		   | +--[LINK N]-->--
		    |	      |->-[flow]-->--|		   | |
	       -->--| QUEUE y |	  ...	     |		   | |
		    |	      |->-[flow]-->--|		   | |
		    +---------+		     +-------------+ |
					       +-------------+
via: https://www.freebsd.org/cgi/man.cgi?query=ipfw&manpath=FreeBSD+9-current&format=html

Dissection: firewall traffic is assigned to a queue, which then generates flows defined by the mask, which pipe into the scheduler (set to FQ_CoDel), which then outputs to the pipe/link at the specified max bitrate.

To assign your traffic to queues, you could do something like I did, which is to use floating rules. I have two WANs, and I need independent shaping and all that, so if you're on a single WAN it may be different for you/you may have better options.

How I set the rules up:

Interface: WAN A or B interface

Direction: out

Address Family: IPv4 or IPv6; I had to do two rules, one for each IP version

Gateway: Select the applicable IPv4 or IPv6 gateway consistent with how traffic should be routed on that IP stack

In / Out pipe: qCHARTERUpload / qCHARTERDownload

I have some filtering rules in play here as you can see in my screenshot, but that's only since I'm testing some issues I mentioned previously. It's up to you if you want to match certain protocols/ports, etc.

Anybody know why when i enable floating rules both upload and download speeds get cut in half? As soon as i disable it, speeds are back to normal.

As far as i can see, traffic both download and upload are getting matched by the interface rules anyway, what is the floating rule for?

zwck

Wrong numbers in the limiters? maybe post some images, so people can help you

zwck

@mattund said in Playing with fq_codel in 2.4:

@slowgrind said in Playing with fq_codel in 2.4:

So after applying the patch do you just fill in the settings under limiters?

Here's what I'm doing. This might be a little more than what you need, but I figure I would share my configuration in case others have a crazy Multi-WAN multi-LAN setup like I do. I've constructed a series of limiters, one for download and one for upload, each with its own associated queue (you can make the queue with the "+ Add new Queue" button on the bottom of a Limiter's settings page) :

(I have more for my second ISP following that naming scheme: lINTERFACEDownload/lINTERFACEUpload and qINTRERFACEDownload/qINTERFACEUpload children)

I'm assigning FQ_CoDel to the scheduler on the parent limiter and leaving everything else alone. You can either edit the parameters, or leave them at default if you have a typical connection (FQ_CoDel is supposed to be "knobless" after all).

According to the following diagram, this is how the traffic will flow inside dummynet:
			    (flow_mask|sched_mask)  sched_mask
		    +---------+	  weight Wx  +-------------+
		    |	      |->-[flow]-->--|		   |-+
	       -->--| QUEUE x |	  ...	     |		   | |
		    |	      |->-[flow]-->--| SCHEDuler N | |
		    +---------+		     |		   | |
			...		     |		   +--[LINK N]-->--
		    +---------+	  weight Wy  |		   | +--[LINK N]-->--
		    |	      |->-[flow]-->--|		   | |
	       -->--| QUEUE y |	  ...	     |		   | |
		    |	      |->-[flow]-->--|		   | |
		    +---------+		     +-------------+ |
					       +-------------+
via: https://www.freebsd.org/cgi/man.cgi?query=ipfw&manpath=FreeBSD+9-current&format=html

Dissection: firewall traffic is assigned to a queue, which then generates flows defined by the mask, which pipe into the scheduler (set to FQ_CoDel), which then outputs to the pipe/link at the specified max bitrate.

To assign your traffic to queues, you could do something like I did, which is to use floating rules. I have two WANs, and I need independent shaping and all that, so if you're on a single WAN it may be different for you/you may have better options.

How I set the rules up:

Interface: WAN A or B interface

Direction: out

Address Family: IPv4 or IPv6; I had to do two rules, one for each IP version

Gateway: Select the applicable IPv4 or IPv6 gateway consistent with how traffic should be routed on that IP stack

In / Out pipe: qCHARTERUpload / qCHARTERDownload

I have some filtering rules in play here as you can see in my screenshot, but that's only since I'm testing some issues I mentioned previously. It's up to you if you want to match certain protocols/ports, etc.

@mattund I have a question here, when you define your floating rule it states in the discription the following:
"If creating a floating rule, if the direction is In then the same rules apply, if the direction is Out the selections are reversed, Out is for incoming and In is for outgoing." Are you doing this or not ?

zwck

@mattund I have a question here, when you define your floating rule it states in the description the following:
"If creating a floating rule, if the direction is In then the same rules apply, if the direction is Out the selections are reversed, Out is for incoming and In is for outgoing." Are you doing this or not ?

netdomon2

wow

dtaht

I am delighted to see all the enthusiasm for fq_codel. For theoretical discussions about how it works please visit the cake or codel mailing lists at lists.bufferbloat.net.

I've been meaning to code review the bsd implementation for a while, I know it has a few limitations and differences from the linux version. In reviewing this thread and all its comments just now I have a few comments. Note I'm primarily an emailer, not a web forum person, but I'll try to pay some attention here, now that I know this thread exists, while you sort out teething pains and new bugs.

do try the simplest possible config first - one shaper + fq_codel. I've generally found that this eliminates the former need for a lot of rules. sqm-scripts has a few of the common rules (like deprioritizing ping) we use in the openwrt world.
does this OS allow for compensating for frame size and spacing (as in dsl/cable/etc). Otherwise if you try to get close, you get bitten by that.

A lot of our motivation for fq_codel and now cake was driven by: https://www.bufferbloat.net/projects/bloat/wiki/Wondershaper_Must_Die/

which references the framing problem.

and if you are going to shape, shape everything, including ping.

your nic shouldn't matter
I don't know if the bulk-dropper in the linux version of fq_codel is in the bsd version. It helps on extreme overloads.
It does sound like there a memory reallocation bug in this version on a reconfigure?
anyone up for a sch_cake port? It's SQM on steroids. https://arxiv.org/pdf/1804.07617

I think that's most of my takeaway from this thread. Another plug is that the flent.org tool we created and use a lot to look hard at all sorts of networking problems - you'll find a lot of "rrul" tests in particular and I'd love to see some of those against your various configurations.

Happy debloating!

--
dave taht
co-founder bufferbloat project

dtaht

I also note that fq_pie was done by the same great folk that did fq_codel, and it benched out pretty good. Even though fq_codel is sort of my adopted baby, I'm pretty agnostic - I just want to beat bufferbloat across the entire internet before I kick the bucket. From what I could see of fq_pie - it looked good also! and I'd really like it if more people also gave it a shot on real world traffic and reported back. thx!

--
dave

zwck

@dtaht et.al thank you!

Harvy66

@dtaht is the man!

dtaht

oh, vey. I'm not "the man". There's a ton of us. (including y'all now!). I'm merely often the most visible and I'm only that because Jim Gettys (who coined the term bufferbloat and convinced me it was such a serious problem that I've now spent 7 years of my life on it) is not much of a public speaker, and ESR told me I only had to be the public face for 5 years before the meme was established and I could retire. And further Vint Cerf, ESR and Jim ganged up on me and told me I had to produce a viable existence proof in one cheap embedded router (cerowrt) before enough people would believe us.

I (we!) kind of owe my career to those guys, so I did that... but cerowrt really burned me out on embedded development. I've been trying to cut way back on "being out there", but finally seeing some major deployment is both very exciting - not just here and on freebsd, but the fq_codel for wifi stuff we did seemingly is spreading like wildfire ( https://arxiv.org/pdf/1703.00064.pdf ) ...

and having unleashed a technology that can make the internet so much better, and after recommending full deployment of fq_codel in 2013 (https://gettys.wordpress.com/2013/07/10/low-latency-requires-smart-queuing-traditional-aqm-is-not-enough/ ) , it's also terrifying... I've spent a lot of time since trying to figure out new problems we've created ( https://github.com/tohojo/flent/issues/148 ) , and in particular ecn and rabid tcp advocates are the most problematic ( https://github.com/systemd/systemd/issues/9725 )

I try always to give full credit to those that created the codel theory (Kathie Nichols & Van Jacobson) and to Eric Dumazet (fq_codel). My portion of the credit was insisting over and over again, with data and proof - to some of the smartest people I've ever met - that AQM was not enough (VJ) and FQ was not enough (Luca Muscarillo ( ) ), and a few theory and implementation fixes along the way with that analysis intact...

We owe an enormous debt to Tom Herbert, who created BQL, and actually made 2 decades of dusty aqm/fq research actually work again in spite of some horrible ongoing practices in the academic community ( some history here: http://conferences.sigcomm.org/sigcomm/2014/doc/slides/137.pdf )

Toke Hoiland-Jorgenson barged into my hotel room one day and insisted he wanted to make bufferbloat the subject of his PHD thesis and has been a truly fundamental driver of much of the improvements that have landed in wifi and runs a great deal of the bufferbloat project now in his spare time. Toke's been the greatest writing partner I've ever had. And he also wrote the wonderful flent.org tool we've used to be able to analyze networks 100s of times faster than other researchers could. (do check it out!)

Pete heist wrote irrt - the first good one way delay measurement tool I've ever used.
( https://github.com/heistp/irtt ). RTT measurements suck if you can't figure out which side of the path is messed up.

There's people like sebastian moeller and kevin derbyshire-bryant that actively maintain and educate those using the sqm-scripts for linux and openwrt and have been really fundamental in finding and fixing obscure framing bugs. John, Jow, and Felix of lede - who were utterly willing to take semi-broken code and test it out in openwrt first.

Ryan mounce showed up out of the blue with a viable ack-filter for sch_cake (http://blog.cerowrt.org/post/ack_filtering/)

Somewhere along the way the whole project had to take on the fcc to keep open source wifi legal (https://www.computerworld.com/article/2993112/security/vint-cerf-and-260-experts-give-fcc-a-plan-to-secure-wi-fi-routers.html ) long enough for us to finish the fq_codel for wifi theory and implementation - and that was fixed by a random guy (michal kazior) showing up with the solution 2 years into us failing to come up with an answer. Given how hard that was elsewhere (example: http://blog.cerowrt.org/post/crypto_fq_bug/ ) I still get kind of teary when I look at the first plot of wifi behaving sanely at all mcs rates. And tearier still with the hundreds of signers of the document we collected that kept our wifi work legal, long enough.

Another random guy discovered he had bufferbloat, fixed it for himself, and was sufficiently POed to go on to write the dslreports bufferbloat tests ( http://www.dslreports.com/speedtest/results/bufferbloat?up ) from which we now have an accurate picture of the size of the problem worldwide. I periodically hit reload on that url, and over the last 6 months those on the left hand side of the 30ms green line has grown markedly - now including all of you! (It's not just the fq_codel deployment but growing upload speeds)

The ietf standardization process for rfc8290 was brutal - not something I'll ever go through willingly again. But that crowd was helpful in its own way.

Corporate support here and there has been helpful too - Jason Livinggood over at comcast funded some of the research, The cablelabs study was extremely helpful. NLNet helped, so did google. But the kind of work we did would have been impossible in a modern corporate environment. Patent attorneys would have been all over us. I'm deeply grateful for the backing of
OIN because attorneys scare me.

Jon Corbet of lwn and Bob Cringely were incredibly helpful. A multitude of other journalists.

Dave Reed - the creator of UDP - has been deeply involved.

John Nagle (author of RFC970 which we cite a lot) has popped out of retirement and writes pithy stuff on reddit.

And then there were other random folk (like, I think @Harvy66) that picked up on the ubnt fq_codel implementation and ran with it until it was so compellingly polished ubnt incorporated it in part of their standard product...

And Grenville Armatrage's team that did the fq_codel and fq_pie implementation (http://caia.swin.edu.au/cv/jkua/preprint/jkua-icccn2017-chunklets-preprint-10may17.pdf ) that you are using....

They also did some great work tearing apart why most ethernet over powerline devices sucked so badly. I've run out of energy for cites....

Nowhere in my life have I seen the power and proof of open source and annoyed engineers scratching an itch, than I have in the bufferbloat project. And nearly absolutely everyone has contributed what they could in their spare time.

And now there's y'all. :)

My hope is that those that successfully deploy fq_codel for themselves will:

A) fix it for at least two friends, and ask them to fix it for two friends each. Fix a local coffee shop, help fix a local business
B) Push their ISPs to supply gear that works right out the box
It's great that we can fix it with another box, but a better default experience for everyone would be better. Another couple years maybe we won't all have to do inbound shaping.
C) Push chipmakers to add BQL and fq_codel to their DSL/cablemodems/other devices...
D) Worry, as I do... about what else is broken on the Internet.

This got kind of long, and no doubt I missed some people, so I'll turn it into a blog entry at some point. I'm not "the man". y'all are.

Happy debloating!

PS I'll try to get around to that code review in the next month or so.

PPS I note, in passing, while karmically rewarding - that this gig doesn't pay very well or often, and I just burned a few months of my life helping finish sch_cake (principal author jon morton and see: https://www.bufferbloat.net/projects/codel/wiki/CakeTechnical/ ) and another openwrt release... and I keep a tip jar here: https://www.patreon.com/dtaht - it doesn't even cover the cost of keeping the servers lit up presently.

I'd rather like to spend a bit of time on webrtc and on ecn in the next year, if i can.

Harvy66

I'm eagerly awaiting DOCSIS 3.1 and PIE.

dtaht

well, if you get used to fq_codel you will find docsis-pie disappointing. However as an out of the box default for improving the uplink it is way better than current cablemodems behave.

Sadly, nothing has been done (that I know of) to kill the overbuffered cmts side of things, where the bulk of the bad experience lies. We're going to need inbound shaping for a decade more yet.