Looking at moving from a consumer wireless router setup to a PFSense one and was interested in seeing if my idea makes sense or I should look at it different.
I have attached the layout plan for now and would be interested in feedback about how i should break it down into vlans, and any other thoughts about it.
I think you're on target there buddy.
Assign VLANS via PFsense, and configure switch trunk ports and access ports as you desire.
As far as I can see, you're golden.
Take your time, and as a rule, if it does not appear to be working after you configure, as a first step, reboot / restart.