Bug: Proxy ARP mode of Virtual IP GUI does not cleanup choparp processess



  • Observed Behavior:

    • choparp processess are spawned whenever Proxy ARP Virtual IP is created in GUI

    • they are not cleaned up when a Proxy ARP VIP is edited or deleted

    To Reproduce:

    • Create a new Virtual IP of type "Proxy ARP" in the Firewall->Virtual IP GUI, WAN iface, single address,

    • Save and click the "Update" button

    • observe with ps and friends a new "choparp" proc is created, with <ip1>as argument</ip1>

    • Edit that existing <ip1>VIP, change only the single address, to</ip1>

    • Save and click the "Update" button

    • observe with ps and friends a new "choparp" proc is created, with <ip2>as argument; there is also still a "choparp" proc running for <ip1>- first bug</ip1></ip2>

    • Delete the <ip2>VIP entirely</ip2>

    • click the "Update" button

    • observe with ps and friends two "choparp" procs running, one for the old <ip1>and the other for the just deleted <ip2>- second bug</ip2></ip1>

    A cursory read of```
    interface_proxyarp_configure()


  • Rebel Alliance Developer Netgate

    If you change step 4 and beyond to delete the VIP for IP1 and then add a new one for IP2, rather than changing the IP Address, does that work as you expect?



  • @jimp:

    If you change step 4 and beyond to delete the VIP for IP1 and then add a new one for IP2, rather than changing the IP Address, does that work as you expect?

    Nope.  If I make step 4 be "delete the VIP for IP1", I still see choparp running for <ip1>afterwards.</ip1>


  • Rebel Alliance Developer Netgate

    I can't reproduce this at all on 2.4. Every change I make is properly reflected in the process list, including deleting addresses, changing IP addresses, or changing subnet masks on larger entries.

    Can you try it again there?



  • Sounds like it might be config dependent then; my setup has bridges and VLAN and OpenVPN etc

    I'll be glad to try when 2.4 releases; glad to hear that signs are positive

    Cheers



  • Hooray!

    Confirmed working on 2.4.0-RC


Log in to reply