Bug v2.4.4



  • here is the bug report not sure where to post it sorry if I post it on the wrong page

    Crash report begins. Anonymous machine information:

    amd64
    11.2-RELEASE-p3
    FreeBSD 11.2-RELEASE-p3 #17 e6b497fa0a3(RELENG_2_4_4): Thu Sep 20 09:04:45 EDT 2018 root@buildbot3:/crossbuild/ce-244/obj/amd64/WvDslnYb/crossbuild/ce-244/pfSense/tmp/FreeBSD-src/sys/pfSense

    Crash report details:

    PHP Errors:
    [01-Oct-2018 10:42:25 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805
    [01-Oct-2018 10:42:41 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805
    [01-Oct-2018 10:42:56 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805
    [01-Oct-2018 10:45:49 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805
    [01-Oct-2018 10:46:03 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805
    [01-Oct-2018 10:46:37 Etc/UTC] PHP Fatal error: Uncaught Error: Only variables can be passed by reference in /etc/inc/pfsense-utils.inc:2805
    Stack trace:
    #0 /usr/local/www/firewall_rules_edit.php(146): filter_rules_sort()
    #1 {main}
    thrown in /etc/inc/pfsense-utils.inc on line 2805

    No FreeBSD crash data found.


  • Netgate Administrator

    What do you do to trigger that php error?

    Steve


  • Rebel Alliance Developer Netgate

    I'm not quite sure how you would have triggered that unless maybe it happened if you deleted every single firewall rule off every interface. Or edited the rules out of a configuration entirely.

    I'm not sure if it would happen then, as it's a bit tricky to test, but I could maybe see it happening.

    If that is what you did, try this patch:

    diff --git a/src/etc/inc/pfsense-utils.inc b/src/etc/inc/pfsense-utils.inc
    index 50d3be60c2..bc68dcb1fc 100644
    --- a/src/etc/inc/pfsense-utils.inc
    +++ b/src/etc/inc/pfsense-utils.inc
    @@ -2794,6 +2794,8 @@ function get_country_name($country_code) {
     function filter_rules_sort() {
     	global $config;
     
    +	init_config_arr(array('filter', 'rule'));
    +
     	/* mark each rule with the sequence number (to retain the order while sorting) */
     	for ($i = 0; isset($config['filter']['rule'][$i]); $i++) {
     		if (!is_array($config['filter']['rule'][$i])) {
    


  • @stephenw10 nothing just a fresh install of pfsense 2.4.4 and I wanted to add rule allow HTTPS and SSH for WAN the only interface I have so I can manage the firewall from there before I add LAN interface and be blocked by the WAN interface

    that's all I did

    EDIT:

    Seems you are right I've removed all the rules from the interfaces after I reinstalled the pfsense and keep the bogon networks rule and first add allow HTTPS and SSH and then removed the bogon rule all seems to work great

    Thank you to all for helping me


  • Rebel Alliance Developer Netgate

    OK, I opened https://redmine.pfsense.org/issues/8993 to track it and committed a fix. As long as you have at least one rule in there on an interface it should be OK. You're lucky the anti-lockout rule was there to prevent you from being shut out of the GUI.

    It's not a situation most people would find themselves in, but it's worth fixing since it's a one-line correction.