[SOLVED] Bug while updating System_Patches

[EveningStarNM]

We are running pfsense 2.4.4-RELEASE-p3 (amd64) built on Wed May 15 18:53:44 EDT 2019 FreeBSD 11.2-RELEASE-p10.

We used the System Patches package to install the update that fixes the bug in which users in the Administrator group could not perform certain administrative functions (although that patch didn't fix the problem for Suricata: members of the administrator group still cannot disable or enable rules.)

Upon being notified that an update was available for the System_Patches package to version 1.2_2, we attempted to install it. The installation log returned an error:

>>> Installing pfSense-pkg-System_Patches... 
Updating pfSense-core repository catalogue...
pfSense-core repository is up to date.
Updating pfSense repository catalogue...
pfSense repository is up to date.
All repositories are up to date.
Checking integrity... done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
	pfSense-pkg-System_Patches: 1.2_2 [pfSense]

Number of packages to be installed: 1
[1/1] Installing pfSense-pkg-System_Patches-1.2_2...
[1/1] Extracting pfSense-pkg-System_Patches-1.2_2: ......... done
Saving updated package information...
done.
Loading package configuration... done.
Configuring package components...
Loading package instructions...

Parse error: syntax error, unexpected ')' in /usr/local/pkg/patches.inc on line 241
pkg-static: POST-INSTALL script failed
>>> Cleaning up cache... done.
Success.

The system log reports the error this way:

[23-Oct-2019 18:19:20 America/Denver] PHP Parse error:  syntax error, unexpected ')' in /usr/local/pkg/patches.inc on line 241

System Packages shows that version1.2_2 has been installed, but the post-installation update script failed with a syntax error, as noted above. We tried uninstalling the package and reinstalling it, but received the same result.

[NogBadTheBad]

https://redmine.pfsense.org/issues/9844

[jimp]

This should be fixed now

[NogBadTheBad]

@jimp Still seem to be getting the Parse error with the update:-

Upgrading pfSense-pkg-System_Patches...
Updating pfSense-core repository catalogue...
pfSense-core repository is up to date.
Updating pfSense repository catalogue...
pfSense repository is up to date.
All repositories are up to date.
The following 1 package(s) will be affected (of 0 checked):

Installed packages to be UPGRADED:
pfSense-pkg-System_Patches: 1.2_2 -> 1.2_3 [pfSense]

Number of packages to be upgraded: 1

11 KiB to be downloaded.
[1/1] Fetching pfSense-pkg-System_Patches-1.2_3.txz: .. done
Checking integrity... done (0 conflicting)
[1/1] Upgrading pfSense-pkg-System_Patches from 1.2_2 to 1.2_3...
[1/1] Extracting pfSense-pkg-System_Patches-1.2_3: ......... done
Removing System_Patches components...
Menu items... done.
Loading package instructions...

Parse error: syntax error, unexpected ')' in /usr/local/pkg/patches.inc on line 241
pkg-static: DEINSTALL script failed
Saving updated package information...
overwrite!
Loading package configuration... done.
Configuring package components...
Loading package instructions...
Custom commands...
Executing custom_php_install_command()...done.
Menu items... done.
Writing configuration... done.

Cleaning up cache... done.
Success

[NogBadTheBad]

@Jimp But a reinstall seems to be fine:-

Upgrading pfSense-pkg-System_Patches...
Updating pfSense-core repository catalogue...
pfSense-core repository is up to date.
Updating pfSense repository catalogue...
pfSense repository is up to date.
All repositories are up to date.
Checking integrity... done (0 conflicting)
The following 1 package(s) will be affected (of 0 checked):

Installed packages to be REINSTALLED:
pfSense-pkg-System_Patches-1.2_3 [pfSense]

Number of packages to be reinstalled: 1
[1/1] Reinstalling pfSense-pkg-System_Patches-1.2_3...
[1/1] Extracting pfSense-pkg-System_Patches-1.2_3: ......... done
Removing System_Patches components...
Menu items... done.
Loading package instructions...
Deinstall commands... done.
Saving updated package information...
overwrite!
Loading package configuration... done.
Configuring package components...
Loading package instructions...
Custom commands...
Executing custom_php_install_command()...done.
Menu items... done.
Writing configuration... done.

Cleaning up cache... done.
Success

[jimp]

That's expected, if you had the broken copy installed, during removal it tries to run a function from there, which fails. But the actual install part worked, and a later reinstall would work. It was fine after that first attempt where you saw the error, if you read the output.

[EveningStarNM]

@jimp Thank you, and to everyone else who replied here, too. I uninstalled v1.2_2 and installed v1..2_3, and everything worked as expected.