What is the pfSense policy to accept PR to fix port?

rickyzhang

I sent a PR to fix Barnyard2 in ARM in Aug, 2019. I saw it was in devel branch in https://github.com/pfsense/FreeBSD-ports.

But I don’t see it in RELENG_2_4_5 branch. Thus, it broke my router again after I upgraded from 2.4.4 to 2.4.5.

What is the process to accept PR from devel branch to release branch?

thanks

commit a60f2a66c321b10550150ef2b0d42e80c1aceea7
Author: Ricky Zhang <rickyzhang@gmail.com>
Date:   Sat Aug 10 18:37:27 2019 +0000

    Disable optimization for armv6 and armv7 to avoid memory unaligned access.

    Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>

commit 50fc4b779a6417568c094dce46b718f5d765e12d
Author: Ricky Zhang <rickyzhang@gmail.com>
Date:   Wed Aug 7 20:23:47 2019 +0000

    Patch SQL syntax error for MariaDB.

    Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>

jdeloach

@rickyzhang said in What is the pfSense policy to accept PR to fix port?:

I sent a PR to fix Barnyard2 in ARM in Aug, 2019. I saw it was in devel branch in https://github.com/pfsense/FreeBSD-ports.

But I don’t see it in RELENG_2_4_5 branch. Thus, it broke my router again after I upgraded from 2.4.4 to 2.4.5.

What is the process to accept PR from devel branch to release branch?

thanks
commit a60f2a66c321b10550150ef2b0d42e80c1aceea7
Author: Ricky Zhang <rickyzhang@gmail.com>
Date:   Sat Aug 10 18:37:27 2019 +0000

    Disable optimization for armv6 and armv7 to avoid memory unaligned access.

    Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>

commit 50fc4b779a6417568c094dce46b718f5d765e12d
Author: Ricky Zhang <rickyzhang@gmail.com>
Date:   Wed Aug 7 20:23:47 2019 +0000

    Patch SQL syntax error for MariaDB.

    Signed-off-by: Ricky Zhang <rickyzhang@gmail.com>

Don't believe Barnyard2 is supported anymore and is scheduled to be removed from Snort and Suricata later this year. See this post from @bmeeks earlier this year: https://forum.netgate.com/topic/149501/important-notice-for-suricata-and-barnyard2-users-barnyard2-will-be-removed-this-year.

rickyzhang

Until that day has come, merge my fix first.

It is a show stopper for me now!