Dhcp server fails to compile with HEAD on FreeBSD 7.1

[nigel]

The port isc-dhcp31-server that is used by HEAD includes a patch that uses a feature of the jail API not included until FreeBSD 7.2

Does anybody have an idea how to fix this??

[Guest]

@nigel:

The port isc-dhcp31-server that is used by HEAD includes a patch that uses a feature of the jail API not included until FreeBSD 7.2

Does anybody have an idea how to fix this??

This is a good question… hope someone knows the solution.

[nigel]

@000000000:

@nigel:

The port isc-dhcp31-server that is used by HEAD includes a patch that uses a feature of the jail API not included until FreeBSD 7.2

Does anybody have an idea how to fix this??

This is a good question… hope someone knows the solution.

OK stupid question. But when I wrote that I was under the impression that HEAD was suppose to work on 7.1
Have since found http://forum.pfsense.org/index.php/topic,16175.0.html which is the only place I have found that mentions 7.2 in regards to HEAD.
I'm a FreeBSD newb that's just spent a week getting HEAD to compile and it's now 4:27 am.

[eri--]

The only way is to improve the patch as

#if FreeBSD_version > $x
do the patch
#endif

[sullrich]

Just commited a fix (hopefully).

[sullrich]

Following Ermals advice leads to:

dhcpd.c: In function 'setup_jail':
dhcpd.c:238: error: 'struct jail' has no member named 'ip4'
dhcpd.c: In function 'main':
dhcpd.c:337: warning: pointer targets in assignment differ in signedness
dhcpd.c:462: warning: pointer targets in assignment differ in signedness
dhcpd.c:463: warning: pointer targets in assignment differ in signedness
dhcpd.c:465: warning: pointer targets in assignment differ in signedness
dhcpd.c:466: warning: pointer targets in assignment differ in signedness
dhcpd.c:468: warning: pointer targets in assignment differ in signedness
dhcpd.c:469: warning: pointer targets in assignment differ in signedness
dhcpd.c:472: warning: pointer targets in assignment differ in signedness
dhcpd.c:473: warning: pointer targets in assignment differ in signedness
dhcpd.c:475: warning: pointer targets in assignment differ in signedness
dhcpd.c:476: warning: pointer targets in assignment differ in signedness
dhcpd.c:480: warning: pointer targets in assignment differ in signedness
dhcpd.c:481: warning: pointer targets in assignment differ in signedness
dhcpd.c:485: warning: pointer targets in assignment differ in signedness
dhcpd.c:487: warning: pointer targets in assignment differ in signedness
dhcpd.c:573: warning: pointer targets in assignment differ in signedness
dhcpd.c:574: warning: pointer targets in passing argument 1 of 'atoi' differ in signedness
*** Error code 1

So this is not the correct fix, Ermal.

[eri--]

Which fix?!

mine was a suggestion :).

Either way i will see this later on.