Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Very big pull request

    Development
    3
    4
    806
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • GertjanG
      Gertjan
      last edited by Gertjan

      Massive pull request : https://github.com/pfsense/pfsense/pull/4488

      Do I read this correctly : 2051 commits
      On 2.4.5 ? I thought the dev base was/is 2.5 ....

      No "help me" PM's please. Use the forum, the community will thank you.
      Edit : and where are the logs ??

      1 Reply Last reply Reply Quote 0
      • bmeeksB
        bmeeks
        last edited by

        Looks like someone accidentally submitted a change for 2.5.0 against
        the 2.4.5 branch.

        DerelictD 1 Reply Last reply Reply Quote 0
        • DerelictD
          Derelict LAYER 8 Netgate @bmeeks
          last edited by

          Yes that looks like #gitfail. (I am guilty of doing exactly the same thing).

          Chattanooga, Tennessee, USA
          A comprehensive network diagram is worth 10,000 words and 15 conference calls.
          DO NOT set a source address/port in a port forward or firewall rule unless you KNOW you need it!
          Do Not Chat For Help! NO_WAN_EGRESS(TM)

          bmeeksB 1 Reply Last reply Reply Quote 0
          • bmeeksB
            bmeeks @Derelict
            last edited by

            @derelict said in Very big pull request:

            Yes that looks like #gitfail. (I am guilty of doing exactly the same thing).

            Yep! Don't ask me how I recognized what the problem is ... 😁.

            1 Reply Last reply Reply Quote 0
            • First post
              Last post
            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.