Just upgraded to 2.50. Is this patch needed?
-
In the system_patches packages I have the following patch...
Here is the contents of the patch:
From b9ed452dbba4689e6280efa7f503e30809a3d8e4 Mon Sep 17 00:00:00 2001
From: jim-p jimp@netgate.com
Date: Tue, 21 May 2019 14:53:02 -0400
Subject: [PATCH] Remove wildcards incorrectly used in isAllowedPage(). Fixes
#9541(cherry picked from commit cf529cbe33ae53f3f95b37a227da141b97465f20)
src/usr/local/www/head.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/src/usr/local/www/head.inc b/src/usr/local/www/head.inc
index 0e7a3a7c6f..208ce4fbd4 100644
--- a/src/usr/local/www/head.inc
+++ b/src/usr/local/www/head.inc
@@ -247,13 +247,13 @@ $system_menu[] = array(gettext("Package Manager"), "/pkg_mgr_installed.php");
$system_menu[] = array(gettext("Setup Wizard"), "/wizard.php?xml=setup_wizard.xml");
$system_menu[] = array(gettext("Routing"), "/system_gateways.php");
$system_menu[] = array(gettext("Cert. Manager"), "/system_camanager.php");
-if (!isAllowedPage("system_usermanager.php*")) {
+if (!isAllowedPage("system_usermanager.php")) {
$system_menu[] = array(gettext("User Manager"), "/system_usermanager_passwordmg.php");
} else {
$system_menu[] = array(gettext("User Manager"), "/system_usermanager.php");
}-if ($user_settings['customsettings'] && isAllowedPage("system_user_settings.php*")) {
+if ($user_settings['customsettings'] && isAllowedPage("system_user_settings.php")) {
$system_menu[] = array(gettext("User Settings"), "/system_user_settings.php");
}The patch ID is: 5ce9d751d7490
If I recall this patch was needed with 2.4.5. Should I just delete this patch in 2.50, revert, or what??
-
You don't need that it's included. You see there you can only revert it.
Steve
-
@stephenw10 I didn't revert the patch, I just deleted it. I assume that works?
-
Yes, that's correct.
It shows you can revert it because it's already in the base code in 2.5.
Steve
