Contributions going forward, in light of pfS+ and CE fork
-
pfsense/CONTRIBUTING.md hasn't been updated since 2017, but a lot has changed.
I was wondering if there are any new guidelines are for PRs/patches. Most of the pfSense devices I work with are going to qualify to run pfSense+. From time to time I'd like to be able to look at parts of the code and possibly submit a PR or two.
I assume the old "fork > patch > submit PR > merge" no longer applies here since only the CE fork will have a public repo? Is that correct?
Let's say we're running pfS+ but notice something that we'd like to work on - should we fork CE and code against that to submit a PR?
Sorry if I've missed the answers to these already somewhere else.
-
As long as the code you're working on is the same in CE and Plus, you can do a PR on CE as usual.
If it's something specific to Plus then that's less well-defined, but we're still considering options there.
Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!
Need help fast? Netgate Global Support!
Do not Chat/PM for help!
-
@jimp Ok thanks. I get that a lot of things are in flux right now. I hope 2021 will be remembered as The Year Of Stabilization.
