WOL wakes ALL devices when trying to wake up ONE device

charly65

Hi,

I've played with WOL a bit and found the following:

After waking up ALL devices ONCE, the URI changes to /services_wol.php?wakeall=true
Then, after manually shutting down all devices and trying to wake up ONE device (still on the same WOL page of the GUI without doing anything else in between), ALL devices are waked up. Easy to reproduce.

A quick look in /usr/local/www/services_wol.php showed that waking a single device uses POST while "Wake All Devices" uses GET, causing the URI to change and stay changed until called fresh from the Service menu.

My quick fix was adding "usepost" to the wakeall condition:

# diff -p /usr/local/www/services_wol.php*
*** /usr/local/www/services_wol.php	2021-03-19 22:23:55.195039000 +0100
--- /usr/local/www/services_wol.php.ori	2021-03-19 23:13:23.658223000 +0100
*************** print $form;
*** 225,231 ****
  			<?=gettext("Add");?>
  		</a>
  
! 		<a href="services_wol.php?wakeall=true" role="button" class="btn btn-primary" usepost>
  			<i class="fa fa-power-off icon-embed-btn"></i>
  			<?=gettext("Wake All Devices")?>
  		</a>
--- 225,231 ----
  			<?=gettext("Add");?>
  		</a>
  
! 		<a href="services_wol.php?wakeall=true" role="button" class="btn btn-primary">
  			<i class="fa fa-power-off icon-embed-btn"></i>
  			<?=gettext("Wake All Devices")?>
  		</a>

Not sure if this is the proper way to fix this but at least it does work for me.
Leaving the final descision for the experts ...

stephenw10

I would open a bug report for that: https://redmine.pfsense.org/

Include the same details you have here. Seems reasonable not to expect that behaviour.

Steve