Package install/upgrading failing in 2.5.2

[wickeren]

On multiple installs I see some packages failing when upgrading, but also on a new install.

Have seen it with:

-Stunnel

• Fatal error: Uncaught Exception: XML error: INCLUDE_FILE at line 37 cannot occur more than once
  in /etc/inc/xmlparse.inc:89
  Stack trace:
  #0 [internal function]: startElement(Resource id #50, 'INCLUDE_FILE', Array)
  #1 /etc/inc/xmlparse.inc(188): xml_parse(Resource id #50, '<?xml version="...', false)
  #2 /etc/inc/xmlparse.inc(160): parse_xml_config_raw('/usr/local/pkg/...', 'packagegui', 'false')
  #3 /etc/inc/pkg-utils.inc(1017): parse_xml_config_pkg('/usr/local/pkg/...', 'packagegui')
  #4 /etc/rc.packages(80): delete_package_xml('stunnel', 'deinstall')
  #5 {main}
  thrown in /etc/inc/xmlparse.inc on line 89
  PHP ERROR: Type: 1, File: /etc/inc/xmlparse.inc, Line: 89, Message: Uncaught Exception: XML error: INCLUDE_FILE at line 37 cannot occur more than once
  in /etc/inc/xmlparse.inc:89
  Stack trace:
  #0 [internal function]: startElement(Resource id #50, 'INCLUDE_FILE', Array)
  #1 /etc/inc/xmlparse.inc(188): xml_parse(Resource id #50, '<?xml version="...', false)
  #2 /etc/inc/xmlparse.inc(160): parse_xml_config_raw('/usr/local/pkg/...', 'packagegui', 'false')
  #3 /etc/inc/pkg-utils.inc(1017): parse_xml_config_pkg('/usr/local/pkg/...', 'packagegui')
  #4 /etc/rc.packages(80): delete_package_xml('stunnel', 'deinstall')
  #5 {main}
  thrownpkg-static: DEINSTALL script failed
  Saving updated package information...
  overwrite!
  Loading package configuration...
  Fatal error: Uncaught Exception: XML error: INCLUDE_FILE at line 37 cannot occur more than once
  in /etc/inc/xmlparse.inc:89
  Stack trace:
  #0 [internal function]: startElement(Resource id #64, 'INCLUDE_FILE', Array)
  #1 /etc/inc/xmlparse.inc(188): xml_parse(Resource id #64, '<?xml version="...', false)
  #2 /etc/inc/xmlparse.inc(160): parse_xml_config_raw('/usr/local/pkg/...', 'packagegui', 'false')
  #3 /etc/inc/pkg-utils.inc(871): parse_xml_config_pkg('/usr/local/pkg/...', 'packagegui')
  #4 /etc/rc.packages(76): install_package_xml('stunnel')
  #5 {main}
  thrown in /etc/inc/xmlparse.inc on line 89
  PHP ERROR: Type: 1, File: /etc/inc/xmlparse.inc, Line: 89, Message: Uncaught Exception: XML error: INCLUDE_FILE at line 37 cannot occur more than once
  in /etc/inc/xmlparse.inc:89
  Stack trace:
  #0 [internal function]: startElement(Resource id #64, 'INCLUDE_FILE', Array)
  #1 /etc/inc/xmlparse.inc(188): xml_parse(Resource id #64, '<?xml version="...', false)
  #2 /etc/inc/xmlparse.inc(160): parse_xml_config_raw('/usr/local/pkg/...', 'packagegui', 'false')
  #3 /etc/inc/pkg-utils.inc(871): parse_xml_config_pkg('/usr/local/pkg/...', 'packagegui')
  #4 /etc/rc.packages(76): install_package_xml('stunnel')
  #5 {main}
  thrownpkg-static: POST-INSTALL script failed*

-Zabbix-agent52

• Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-agent.inc on line 379
  pkg-static: POST-INSTALL script failed*

Zabbix-proxy52

• Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-proxy.inc on line 358
  pkg-static: DEINSTALL script failed
  Saving updated package information...
  overwrite!
  Loading package configuration... done.
  Configuring package components...
  Loading package instructions...

Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-proxy.inc on line 358
pkg-static: POST-INSTALL script failed*

Probably some more too, while others like Haproxy, Suricata and Wireguard all go OK.

Anyone else seeing this? PHP upgrade thing in 2.5.2 maybe?

Julian

[Gertjan]

"all packages" or just Zabbix ?
Related to https://forum.netgate.com/topic/165142/pfsense-pkg-zabbix-agent5-1-0-4_7-txz-may-be-broken/4?_=1626340098304 ?

[wickeren]

@gertjan

Stunnel too

[captainbablam]

@wickeren PFBlocker as well. Looks like dns records are missing?

[captainbablam]

@captainbablam

[Gertjan]

@captainbablam

Read this https://docs.netgate.com/pfsense/en/latest/troubleshooting/upgrades.html#packages-netgate-com-has-no-a-aaaa-record ;)

edit :

While you there, read all of Troubleshooting Upgrades.

[wickeren]

@gertjan

Issue I was talking about isn’t dns related. It was some typo in the packages (zabbix/stunnel) itself and is fixed now. Probably it was caused by a more strict syntax check in 2.5.2