pfSense-pkg-zabbix-agent5-1.0.4_7.txz may be broken

steve.scotter

I'm upgrading our Zabbix inf from v4 to v5.

Yesterday I updated the zabbix packages on two of our pfsense boxes. The installed packages were :
zabbix-proxy5 1.0.4_6
zabbix-agent5 1.0.4_7

Installation went fine and I had no problems at all.

Today, I'm trying to update a second separate pair of pfsense boxes.

When I install zabbix-proxy5 it completes but doesn't appear in the Services menu. I then noticed a crash report had been generated. Inside the crash report I see

[15-Jul-2021 07:21:55 Etc/Greenwich] PHP Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-proxy.inc on line 358

When I've checked, the version I'm installing today is zabbix-proxy5 1.0.4_7 (minor increment from yesterday).

I fetched 1.0.4_6 from http://files00.netgate.com/pfSense_v2_4_5_amd64-pfSense_v2_4_5/All/pfSense-pkg-zabbix-proxy5-1.0.4_6.txz and installed on the command line with a pkg install pfSense-pkg-zabbix-agent5-1.0.4_6.txz

When I checked the pfsense boxes I updated yesterday both are indicating there's an update available for zabbix-agent5 so I think 1.0.4_7 was released in the past 24hrs.

Looking at zabbix-proxy.inc (below are lines 356-359) it looks as though it's missing an addition ) after $zabbixconf['tlscertfile'] != 'none'

	if (($pluginparams['event'] == 'used_certificates') && !empty($zabbixconf['tlscertfile']) &&
	    ($zabbixconf['tlscertfile'] != 'none') {
		$result['pkgname'] = "Zabbix Proxy";
		$result['certificatelist'] = array();

How can I contact the author of the plugin to try and resolve the issue?

The Zabbix-agent package has similar issues.

PHP Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-agent.inc on line 379

steve.scotter

Forgot to mention, all pfsense boxes are running v2.5.2

steve.scotter

I think I'm on the right track.. Performed a php lint on the file before and after changing ($zabbixconf['tlscertfile'] != 'none') { to ($zabbixconf['tlscertfile'] != 'none')) { on line 357.

Before
Parse error: syntax error, unexpected ';' in /usr/local/pkg/zabbix-proxy.inc on line 358 Errors parsing /usr/local/pkg/zabbix-proxy.inc

After
php -l /usr/local/pkg/zabbix-proxy.inc No syntax errors detected in /usr/local/pkg/zabbix-proxy.inc

However, it hasn't made Zabbix Proxy appear in the Services menu

steve.scotter

Did some googling to find how to report problems to pfsense and found the bug tracker at redmine.pfsense.org. This issue with Zabbix has been reported 9 hours ago by DRago_Angel [InV@DER] and a fix has been implemented.

https://redmine.pfsense.org/issues/12128

Sorry for the noise!

viktor_g

agent/proxy update coming soon

for now you can manually add a closing parenthesis to the corresponding files,
see https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504426
and
https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504350

provels

@viktor_g
FWIW, looks like zabbix4-agent-4.0.30 suffers same issue.

steve.scotter

@viktor_g said in pfSense-pkg-zabbix-agent5-1.0.4_7.txz may be broken:

agent/proxy update coming soon

for now you can manually add a closing parenthesis to the corresponding files,
see https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504426
and
https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504350

@viktor_g I added the missing closing parenthesis.. it stopped the crash notifications but didn't make zabbix-proxy or zabbix-agent appear in the Services me though. Is there anything else I needed to do?

provels

@steve-scotter said in pfSense-pkg-zabbix-agent5-1.0.4_7.txz may be broken:

@viktor_g said in pfSense-pkg-zabbix-agent5-1.0.4_7.txz may be broken:

agent/proxy update coming soon

for now you can manually add a closing parenthesis to the corresponding files,
see https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504426
and
https://github.com/pfsense/FreeBSD-ports/commit/6eb71b010f8a0d25f989561785ad799fac6ff04f#r53504350

@viktor_g I added the missing closing parenthesis.. it stopped the crash notifications but didn't make zabbix-proxy or zabbix-agent appear in the Services me though. Is there anything else I needed to do?

FWIW, I added the paren and rebooted. Though it doesn't show in Services, it is logging data now (4.x).

viktor_g

Please update to the latest Zabbix agent/proxy version

steve.scotter

@viktor_g
zabbix-agent5 1.0.4_9 and zabbix-proxy5 1.0.4_8 now installed and working perfectly.

Thanks!

provels

@viktor_g
v 4.x fixed.