Stray commented line in pfsense/src/etc/inc/openvpn.inc
-
The part of the code which sets the management interface for OpenVPN is commented in the code here:
https://github.com/pfsense/pfsense/blob/1394773d4cea75cb39c82bd42b4531755599a440/src/etc/inc/openvpn.inc#L1105-L1109.Does it hold any significance?
-
The first line sets it up as a unix socket and that's what is used by pfSense internally, so it's fine.
The second line is a remnant of the past when it was setup to use a network socket, not a unix socket. That is less secure and also requires making sure nothing else uses a conflicting port. That commented line can probably be removed.
Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!
Need help fast? Netgate Global Support!
Do not Chat/PM for help!
-
From looking at the commit which made this change, this seems like it was commented out purposefully back then. Should I open a PR to remove those lines?
-
@pandafy said in Stray commented line in pfsense/src/etc/inc/openvpn.inc:
From looking at the commit which made this change, this seems like it was commented out purposefully back then. Should I open a PR to remove those lines?
That would be fine, I'd say being commented out for over 11 years means we really don't need to keep them hanging around.
