small gateway bug after 23.01 upgrade?

JeGr

Hi,

we updated a customer machine to 23.01 this morning and had a strange problem afterwards, that the customer reported everything fine but his VPN wasn't working as in "we can't reach the remote site, but the connection is up".

Checked the OVPNC connection (it is configured as OpenVPN Client) and that seemed fine as before. Also the GW was showing up and reporting no loss. As we don't pull routes we have configured a few policy based rules with said VPN gateway. And that's where the strange "bug" popped up: all rules with the VPN gateway had that gateway written in "b/w font" - as in it wasn't a link with a popup anymore. Other GWs from MultiWAN etc. were fine. So just edited all rules that had that VPN GW and sure thing, when editing the rules, the gateway under advanced option was empty. I selected the VPN GW again and all started working fine.

After checking again what changed, the only thing that catched my eye was the VPN GW name.

In 22.05 that name was: VDE_COMPANY_VPNV4
In 23.01 that name was: VDA_Company_VPNV4

So it seems upper/lowercase naming of the interface assignment jumped into the fray(?) and "crashed" all policy rules with the gateway now in mixed upper-/lowercase instead of all CAPS.

Don't know it that was a special thing in that config but perhaps there is some check there that is now case-sensitive that wasn't before? Just wanted to report that back.

Cheers
\jens

jimp

That seems vaguely familiar but I thought we had addressed it a while back during 23.01 development, but maybe that particular path didn't get fixed up.

You could rename the interface to all caps so the gateways would also match the case that way.

jimp

This is the one I was thinking of:
https://redmine.pfsense.org/issues/13739

But that would have only been for interfaces without a description, not for gateway names. There must be some other issue lurking here yet.

jimp

I was able to at least confirm the previous vs current behavior. I opened https://redmine.pfsense.org/issues/14057 to look into this.

jimp

That was a fun one, it appears to be from one single line that had some logic flipped when it was converted to be compatible with PHP 8:

diff --git a/src/etc/inc/util.inc b/src/etc/inc/util.inc
index b1d630378a..30f402de1a 100644
--- a/src/etc/inc/util.inc
+++ b/src/etc/inc/util.inc
@@ -1538,7 +1538,7 @@ function get_configured_interface_with_descr(bool $with_disabled = false) : arra
        $iflist = [];
        foreach (config_get_path('interfaces', []) as $if => $if_detail) {
                if ($with_disabled || isset($if_detail['enable'])) {
-                       $iflist[$if] = array_get_path($if_detail, 'descr', strtoupper($if));
+                       $iflist[$if] = strtoupper(array_get_path($if_detail, 'descr', $if));
                }
        }

JeGr

@jimp Argh no way - a one-liner and a PHP8 conversion no less? That's a mean one But thanks for tackling that so fast! As said, it was more of a small annoyance to edit the PBRs but it was up in no time, so why not. But yeah, didn't think about renaming the OPT interface to CAPS - that would've been faster

But happy to weed out yet another little nuisance

Cheers
\jens

bcdouglas

@jimp This seems like a pretty annoying and weird bug. Does a fix really have to wait until 23.05? Can we get it as a patch sooner? Frankly, I've given up on 23.01 due to weird IPv6 issues. I'm even on Netgate hardware, 6100.

jimp

@bcdouglas said in small gateway bug after 23.01 upgrade?:

@jimp This seems like a pretty annoying and weird bug. Does a fix really have to wait until 23.05? Can we get it as a patch sooner? Frankly, I've given up on 23.01 due to weird IPv6 issues. I'm even on Netgate hardware, 6100.

You can apply the patch any time. A copy is a few replies up or you can install the System Patches package and create an entry for 66b989e824042c0cf5e75b1cb245b0ae13548949 and fetch/apply it.

If we make a patch release before 23.05 this is almost certainly going to be included, but until/unless that happens, patching it in is the way to do.

You can also rename your interface to be all caps to work around it without patching anything.

JeGr

@jimp Applied the patch yesterday and had to change back all and every changed GW that was saved with lowercase back to uppercase. As manually created GWs can be lowercase, too and Interface names can have that, why not simply make it case insensitive to both work? That way one wouldn't have to switch back and forth between upper or lowercase? Made the whole setup break again :/

jimp

@jegr said in small gateway bug after 23.01 upgrade?:

@jimp Applied the patch yesterday and had to change back all and every changed GW that was saved with lowercase back to uppercase. As manually created GWs can be lowercase, too and Interface names can have that, why not simply make it case insensitive to both work? That way one wouldn't have to switch back and forth between upper or lowercase? Made the whole setup break again :/

That is a much more significant (and likely disruptive!) change than putting the automatic names back the way they should have been.

Manual entries would not have changed and wouldn't have had any issues (upper or lower), only fully dynamic entries were a problem.