System Patches package version 2.2.x

[JonathanLee]

@jimp thanks!!!

[JonathanLee]

@jimp speaking of patches, how long until they are approved to be added in as recommend? For example the YouTube issue with none.
https://redmine.pfsense.org/issues/13811

[jimp]

@jonathanlee said in System Patches package version 2.2:

@jimp speaking of patches, how long until they are approved to be added in as recommend? For example the YouTube issue with none.
https://redmine.pfsense.org/issues/13811

There isn't any set schedule, mostly depends on the amount of time devs have who are also familiar with the package and so on. But that's completely unrelated to this thread, "patches" in the sense of this package are not always tied to PRs or commits.

[jimp]

There is another update coming here shortly, which addresses two things:

• The alias sorting did have an issue if the aliases were not sorted in the configuration (which normally happens on save or other change to aliases). Most people wouldn't see a problem here, but some could. So there is a patch that applies on top of the previous patch to use a better sort method that has the ideal sort order but also preserves index keys.
• When doing 'revert all' it was iterating the patch list from the top down which fails if a later patch requires an earlier patch to be applied first. The two patches would apply OK but when reverting all patches it would only revert the later patch, not the earlier one. So reverting from the last to the first ensures this order is properly respected.

Users on 23.01 will see a new patch to apply. Users on older versions will not see any new patches but the revert all order will be fixed.

[keyser]

@jimp Nice one.

Considering the list of of patches for 23.01 this fra, is there any chance a 23.01.1 will be released with everything included?

For all those boxes not at 23.01 yet?

[jimp]

@keyser said in System Patches package version 2.2:

@jimp Nice one.

Considering the list of of patches for 23.01 this fra, is there any chance a 23.01.1 will be released with everything included?

For all those boxes not at 23.01 yet?

We are still considering our options there, but the next release is due in May and it's already almost April at this point. Having to turn out a point release would leave us very little time to work on items we want to complete for 23.05. But we're keeping an eye on things and if we do decide that, we'll announce it in various places.

[JonathanLee]

@jimp Installed Thank you!!

[OffstageRoller]

Thank you for this! It’s awesome that I don’t have to hunt down patches, nor wait for the next OS release to get these, and it’s all done in a single click (and reboot).

What would be the process when the next version of pfSense is released? Normally I:

1. Reboot
2. Uninstall all packages
3. Upgrade
4. Reboot
5. Reinstall all packages

But with all of these recommended patches, before I do step 1 above, should I first revert all patches applied?

Or is it safe to keep all the patches applied and install the upgrade as is? Can the patches package be removed with patches still applied before upgrading?

My fear would be a patch the applied to 23.01, but didn’t make it to 23.05, and now I still have that modified file on my disk, but it’s not available to be installed/reverted in version 23.05. Does that make sense what I’m trying to say?

[SteveITS]

@offstageroller normally the Recommended patches are all included in the next version. If not (which I haven’t seen yet) then presumably either something’s wrong with the patch, or it would still be listed in the package for the next version.

[slu]

@jimp said in System Patches package version 2.2:

This function is really fantastic!

[JeGr]

@jimp As you mention 23.05 around the corner I'm curious: what's the plan with 2.7? Release before 23.05 or joint release with 23.05 (shortly after)? We've many people asking when the step-up to 2.7 will arrive (mostly because they also have to plan maint windows in advance) so even a guesstimate would be nice.

As the snaps of 2.7 haven't gone beta yet I'm wondering :)

Cheers

[jimp]

@jegr said in System Patches package version 2.2:

@jimp As you mention 23.05 around the corner I'm curious: what's the plan with 2.7? Release before 23.05 or joint release with 23.05 (shortly after)? We've many people asking when the step-up to 2.7 will arrive (mostly because they also have to plan maint windows in advance) so even a guesstimate would be nice.

As the snaps of 2.7 haven't gone beta yet I'm wondering :)

Not a topic for this thread, but still being discussed internally, likely after.

[Dobby_]

I am on pfSense+ 23.01 with system patches 2.2.1
and all is running fine for now. Well done!

[jimp]

Bumping thread, 2.2.2 is building now, see edit in the main post for info.

tl;dr 9 new patches for 23.01, no changes for other versions.

[johnpoz]

@jimp so take in when it shows as available just update and reapply, no need to revert and then apply - that sort of thing. Or apply just new ones that show up.

[jimp]

Update the package, look over the list and just apply anything you think you might benefit from that isn't already applied. Or whack the apply all recommended button again and it'll just apply all the new stuff.

No need to revert or touch anything before/after otherwise.

[JonathanLee]

@jimp Thank you, I appreciate all you do. It's working great on my 2100 MAX

[JonathanLee]

@jimp @LamaZ Your patch for authenticated NTP status is also still working.

[keyser]

@jimp said in System Patches package version 2.2.x:

Update the package, look over the list and just apply anything you think you might benefit from that isn't already applied. Or whack the apply all recommended button again and it'll just apply all the new stuff.

No need to revert or touch anything before/after otherwise.

While I really applaude this patch manager and the delivery mechanism it brings, I would like to add that unless 23.05 is right around the corner, it’s my firm belief that a 23.01.1 should be released asap.
It’s a long list of patches now, and waiting many months before they are applied to the average 23.01 upgrader, is simply not the right solution in my opinion.

[jimp]

@keyser said in System Patches package version 2.2.x:

@jimp said in System Patches package version 2.2.x:

Update the package, look over the list and just apply anything you think you might benefit from that isn't already applied. Or whack the apply all recommended button again and it'll just apply all the new stuff.

No need to revert or touch anything before/after otherwise.

While I really applaude this patch manager and the delivery mechanism it brings, I would like to add that unless 23.05 is right around the corner, it’s my firm belief that a 23.01.1 should be released asap.
It’s a long list of patches now, and waiting many months before they are applied to the average 23.01 upgrader, is simply not the right solution in my opinion.

23.05 is targeted for early May (before BSDCan), we're already in the first stages of the release cycle and things are looking pretty good overall. At this point it would take us longer to shift gears and put out a patch release than to keep moving forward.