Should I uninstall a patch before/after an upgrade?
-
I installed a patch for the high use memory issues (something about default chron jobs) with the previous release. I recently upgraded to latest and that patch still shows as applied but it really applies to the previous release of pfSense. Should I uninstall it or leave it as it is? Nothing is wrong so I don't have a reason to other than potential future issues. Thanks for the thoughts on this.
-
The System_Patches, currently version 2.2.3, is advised to install, and also, if it proposes 'build in' patches, you should 'apply' them all.
There is nothing more to do.@scottlindner said in Should I uninstall a patch before/after an upgrade?:
I recently upgraded to latest and that patch still shows as applied but it really applies to the previous release of pfSense
There is an incoherence.
If you've upgraded (pfSense) that a patch you've put in place is still there, and can still be applied, this means that the issue that the patch addresses is still teher.
It can't apply against a previous version of pfSense, as it isn't there anymore.
Btw : You didn't say so, but I presume you talk about a patch that you added manually.If this patch was 'valid' for, example 23.01 - and the patch (solution) didn't make it 23.05 then the patch would still match, and you could still apply it for 23.05.
Normally, when you've used the System_Patches under 23.01, there were several build in patches that all could be applied.
When upgrading to 23.05, the System_Patches package also upgraded, and now there are no build in patches anymore.
As the previous ones are no all part of 23.05 "out of the box".You can continue to add manual patches, I've 3 of the right now :
-
previous ones are no all part of 23.05 "out of the box"..
To clarify I think that was a typo, meant to be “now all part.”
The cron patch did become a Recommended patch along with about 30 others. Those get included in later versions. If you’d manually applied it IIRC it will still show after pfSense upgrade but since code was updated you wouldn’t want to unapply it. If it lets you; it won’t if the code changed out from under the patch.
Overall in this case I’d just delete the manual patch entry.
-
-
Thank you. I just removed the patch. It can be applied again if that memory issue returns. I was curious if it would automatically remove the patch since it doesn't apply to 23.05. But then wondered what the patch tool would do if I deleted a patch on a new release.
-
If you added a patch manually and that fix is included in the new release, then just delete the entry from the package without touching it.
If you revert a patch after upgrading you undo the fix and put back the bad code.
Manual patch entries are never automatically removed. Only the "recommended" list changes automatically by version.