Multiple issues on RELENG_2_7_0 GitHub Source Code.

fabricioguzzy

@jimp - Hi Jim, Good day.
I am writing to report several different issues with the RELENG_2_7_0 github code a follow:

1- pfsense/tools/builder_defaults.sh - It's still pointing to RELENG_2_6_0 and RELENG_2_5_2 (lines 59 & 60)
2- pfsense/tools/builder_defaults.sh - It points to FreeBSD-src "devel-12" branch, not "RELENG_2_7_0" as required. (Line 118)
3- pfsense/tools/builder_defaults.sh - It looks for "/release/conf/${PRODUCT_NAME}_src-env.conf" which doesn't exist anymore under FreeBSD-src/release/conf folder. (Line 135)
4- pfsense/tools/builder_defaults.sh - requires a dev module "ndis" which is not present on FreeBSD-src RELENG_2_7_0 branch. (Line 149)
5- pfsense/tools/builder_common.sh - The part of the script to rename the php-pfsense-module (for those who compile it with a different name like me) is now broken as the php-module has changed (php82) - I have changed it to follow the new files and etc, but it does deserve a better review as I am not familiar with the php-pfsense-module file. (starts at Line 1584)
Code Below:

# PHP module is special
		if echo "${_pname}" | grep -q "^php[0-9]*-${PRODUCT_NAME}-module"; then
			local _product_capital=$(echo ${PRODUCT_NAME} | tr '[a-z]' '[A-Z]')
			sed -i '' -e "s,PHP_PFSENSE,PHP_${_product_capital},g" \
				  -e "s,PFSENSE_SHARED_LIBADD,${_product_capital}_SHARED_LIBADD,g" \
				  -e "s,pfSense,${PRODUCT_NAME},g" \
				  -e "s,pfSense_arginfo.h,${PRODUCT_NAME}_arginfo\.h,g" \
				  -e "s,pfSense_private.h,${PRODUCT_NAME}_private\.h,g" \
				  -e "s,pfSense.c,${PRODUCT_NAME}\.c,g" \
				${_pdir}/${_pname}/files/config.m4

			sed -i '' -e "s,COMPILE_DL_PFSENSE,COMPILE_DL_${_product_capital}," \
				  -e "s,pfSense_module_entry,${PRODUCT_NAME}_module_entry,g" \
				  -e "s,php_pfSense.h,php_${PRODUCT_NAME}\.h,g" \
				  -e "s,pfSense_arginfo.h,${PRODUCT_NAME}_arginfo\.h,g" \
				  -e "s,pfSense_private.h,${PRODUCT_NAME}_private\.h,g" \
				  -e "/ZEND_GET_MODULE/ s,pfSense,${PRODUCT_NAME}," \
				  -e "/PHP_PFSENSE_WORLD_EXTNAME/ s,pfSense,${PRODUCT_NAME}," \
				${_pdir}/${_pname}/files/pfSense.c \
				${_pdir}/${_pname}/files/pfSense_arginfo.h \
				${_pdir}/${_pname}/files/pfSense.stub.php \
				${_pdir}/${_pname}/files/pfSense_private.h \
				${_pdir}/${_pname}/files/php_pfSense.h
		fi

6- The FreeBSD-src RELENG_2_7_0 branch seems to use a DEBUG kernel with several debug flags enabled and a problem with the ZFS module which seems to be Disabled.
7 - A new port called "pfSense-repoc" seems to point to an internal Netgate URL, so it's impossible to compile it. That port is now replacing part of a php function called "update_repo()" which calls a binary file with the "pfsense-repoc" name - for those who compile pfsense from the sources, that doesn't work and we are obligated to rewrite the function as it was under Releng_2_6_0.

Those are the issues I have found so far with the Github code for pfsense RELENG_2_7_0.
Do you guys intend to update it?

Thank you,
Cordially,
Fabricio.

dyeske

Thank you for doing this important research Fabricio. I apologize if I have misspelled your name. Please connect with me. I have information that can help both of us.

airportsingle

This post is deleted!