System Advanced >Networking

gawd21

I am getting this every time I click on System, Advanced, Networking:

Fatal error: Uncaught ValueError: fread(): Argument #2 ($length) must be greater than 0 in /etc/inc/util.inc:3480 Stack trace: #0 /etc/inc/util.inc(3480): fread(Resource id #11, 0) #1 /usr/local/pfSense/include/www/system_advanced_network.inc(47): get_duid_from_file() #2 /usr/local/www/system_advanced_network.php(55): getAdvancedNetwork() #3 {main} thrown in /etc/inc/util.inc on line 3480 PHP ERROR: Type: 1, File: /etc/inc/util.inc, Line: 3480, Message: Uncaught ValueError: fread(): Argument #2 ($length) must be greater than 0 in /etc/inc/util.inc:3480 Stack trace: #0 /etc/inc/util.inc(3480): fread(Resource id #11, 0) #1 /usr/local/pfSense/include/www/system_advanced_network.inc(47): get_duid_from_file() #2 /usr/local/www/system_advanced_network.php(55): getAdvancedNetwork() #3 {main} thrown

Here is the crash report:

Crash report begins.  Anonymous machine information:

amd64
14.0-CURRENT
FreeBSD 14.0-CURRENT #1 plus-RELENG_23_05_1-n256108-459fc493a87: Wed Jun 28 04:26:04 UTC 2023     root@freebsd:/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/obj/amd64/f2Em2w3l/var/jenkins/workspace/pfSense-Plus-snapshots-23_05_1-main/sources/

Crash report details:

PHP Errors:
[17-Aug-2023 07:20:38 XXXXXXXXXXXXXXXXXXX] PHP Fatal error:  Uncaught ValueError: fread(): Argument #2 ($length) must be greater than 0 in /etc/inc/util.inc:3480
Stack trace:
#0 /etc/inc/util.inc(3480): fread(Resource id #11, 0)
#1 /usr/local/pfSense/include/www/system_advanced_network.inc(47): get_duid_from_file()
#2 /usr/local/www/system_advanced_network.php(55): getAdvancedNetwork()
#3 {main}
  thrown in /etc/inc/util.inc on line 3480



No FreeBSD crash data found.

Intel Celeron N5105
16Gigs RAM
256 M.2 NVMe
Temps almost never go above 40C
Most of the time in the lower 30's
Three LAN's with one disabled (the one with the NVR).
All four nics are the Intel v226
If you need anymore info, just ask.

The system has been a thorn in my side ever since I updated to 23.05.01. First the whole thing would ignore all firewall rules. Then it would allow access to the internet, but not to anyother LAN's. Finally I just did a restore from a backup I had. Everything was working great for a few days, now it's falling apart again.
It all started when I tried to setup multicast from one lan to another with the first having the wireless doorbell and the second the NVR with no internet access. Never got that working as the system issues started so I had to focus on them.
Any idea, other than just wiping and starting over?

Don't know if this is related, but I cannot get it to stop trying to use IPv6. Disabled everywhere I can think of, but it is always filling my logs up with blocked connections.

EDIT: I was digging around, just to learn, and lines 3469 -3490 are:

/* returns duid string from 'vardb_path']}/dhcp6c_duid' */
function get_duid_from_file() {
	global $g;

	$duid_ASCII = "";
	$count = 0;

	if (file_exists("{$g['vardb_path']}/dhcp6c_duid") &&
	    ($fd = fopen("{$g['vardb_path']}/dhcp6c_duid", "r"))) {
		$fsize = filesize("{$g['vardb_path']}/dhcp6c_duid");
		if ($fsize <= 132) {
			$buffer = fread($fd, $fsize);
			while($count < $fsize) {
				$duid_ASCII .= bin2hex($buffer[$count]);
				$count++;
				if($count < $fsize) {
					$duid_ASCII .= ":";
				}
			}
		}
		fclose($fd);
	}

With the error calling out "Argument #2 ($length)" and I do not see that in there, but (what I am guessing to be) Argument #2 is ($fsize). I do have the "original" util.inc that I can check if it has the length vs size. If I am even on the right page with this... No clue. util.inc 112.05 KiB, util.inc.orig 109.08 KiB

EDIT #2: I tried the original, same error just a different line, so I then tried the fix from https://redmine.pfsense.org/issues/14256 and it was again the same error, but again a different line. I went back to the file that I started out with with them error. So still have the error 3480.

bmeeks

While there is a bug in the way the pfSense PHP code is handling the problem (in my opinion at least), your core issue is a corrupt or missing dhcp6c_duid file in /var/db/. There should be a file there with a value in it, and thus its length would be greater than zero. The error you posted is triggered because that file on your system is empty when it should not be. The code first asks for the size of that file with the filesize() function. The code then attempts to read a block of data from the file equal to the returned file size. Because the filesize() function is returning zero, which is illegal so far as the PHP fread() function is concerned, the error is thrown when the read is attempted.

On your system that file is either missing or empty. I'm leaning toward empty as missing would likely throw a different kind of error.

You should report this bug, along with the contents (or lack thereof) of your dhcp6c_duid file on the Redmine bug tracking system here: https://redmine.pfsense.org/projects/pfsense.

gawd21

@bmeeks

Thank you very, very much for explaining that to me! Yes, the file is zeroed out. I don't have a back up of it either for some reason. I might in an older version. I will report the bug. I wonder if I just put in come commented out text in the file if it will correct the issue.

stephenw10

What do you have 'DHCP6 DUID' set to on that page? Was that setting something you changed previously?

bmeeks

@gawd21 said in System Advanced >Networking:

I wonder if I just put in come commented out text in the file if it will correct the issue.

It would prevent the immediate error, but may cause grief further down in the code someplace. I'm not an IPv6 expert, but I believe that file is supposed to contain the default DUID for your firewall. I looked at mine and it contains binary characters as they do not display properly in the DIAGNOSTICS > EDIT FILE menu option.

gawd21

@stephenw10
I had just unchecked it a while back. I can't remember the layout of the page, but I am sure it had a check box that all ipv6 will be disabled if unchecked. However, I haven't made any changes on that page since maybe June. I am thinking the issues occurred when I restored the backup, on the 15th.

stephenw10

Yes it should be populated. But since it exists it's checking it. Feels like it might not be referencing it, the DUID setting set to something other than default, and it should have been removed?

gawd21

@bmeeks
Well that would cut off my next question. LOL I was going to see if I could get the code, however, it may contain private info, so wouldn't be a good idea for anyone to share the file, plus different configs and all.

stephenw10

By default it references that file like this:

Screenshot from 2023-08-17 15-02-44.png

Gertjan

@bmeeks said in System Advanced >Networking:

On your system that file is either missing or empty.

It exists and is empty.
If it was missing, the first test, file_exists("{$g['vardb_path']}/dhcp6c_duid") would fail.

Btw : This is mine : 16 bytes - so less then 132.

I have IPv6 activated on WAN and LAN, and using IPv6 right on this forum.

The question is : what creates a empty /var/db/dhcp6c_duid file ?
Answer : it's in the same file /etc/inc/util.inc - 15 lines above :

function write_dhcp6_duid($duidstring)

and this function will first check if the $duidstring contains a valid duid using the fucntion is_duid() (in the same file).

function is_duid() is really throwing a maximum effort in proving that $duidstring is not a duid and it will return false if the there is a problem, like $duidstring not being a $duidstring.

If function is_duid() reurn true, then the /var/db/dhcp6c_duid file is created with the $duidstring content.

What is the time stamp of this file ? It dates from when ?

If pfSense can not create that file because there is not a valid or empty $duidstring - should it keep the file in place
or
just delete the file ?

The /var/db/dhcp6c_duid is only created or updates on one place : function write_dhcp6_duid($duidstring) - I can't see how this function can create an empty file.

I vote for : just wipe the zero length file /var/db/dhcp6c_duid and call it a day.

Note to myself : who is this dude ?

gawd21

@stephenw10
I put this in and it allowed me to access the page.

/* ignore this test */

However, it just shows the -:-: and none of the numbers like yours.

stephenw10

Yup what is coming from that file and yours is empty.

I agree, try deleting the file and see if it's regenerated.

gawd21

@stephenw10 I deleted it. Waiting to reboot.

gawd21

File was not created on reboot.

gawd21

@Gertjan

It wasn't created on reboot, and I just noticed that /var/dhcpd/var/db/dhcpd6.leases is also a zeroed out file. I wonder if I have a bad stick of RAM.

stephenw10

And that removed the error I assume?

Any guess what combination of settings created that file without content? I'll try to replicate it.

gawd21

@stephenw10

It's not the file that is zeroed out, the /var/dhcpd/var/db/dhcpd6.leases is too.

It maybe bad RAM.
I was having a bunch of problems with multicast working and I am sure that I changed something that I shouldn't have, in my frustration and after hours of messing with it, my network started to fall apart as in I couldn't communicate with other lans and everything was going very slowly, even loading the diag page too seconds, so I said the hell with it and restored my backup from right after the update to 23.05.01, that was on the 15th. Yesterday/early this morning, I say IPv6 traffic and I went to go check the networking page to make sure it was off and that is when I found the error.

Yes, the error is gone now.

gawd21

@stephenw10 Firefox_Screenshot_2023-08-17T14-47-57.748Z.png

Gertjan

@gawd21 said in System Advanced >Networking:

/var/dhcpd/var/db/dhcpd6.leases is also a zeroed out file

That's another animal.
Created by the DHCP IPv6 server, who servers IPv6 leases on your LANs for the devices that want to do IPv6 networking.

Again : what is the time stamp of the file ?
Maybe you had the DHCP v6 servers active on your LANs in the past ?

You can delete this file.

This file is a scrath pad for the DHCP v6 server process, so it knows, even after a power down, and power up, what device had what lease when.
And it permits to show in the GUI all the DHCPv6 leases handed out.

gawd21

@Gertjan said in System Advanced >Networking:

/var/dhcpd/var/db/

05-10-2023 02:54