Traffic graph not shown for local ips

[stephenw10]

Huh, that in itself seems like a bug. Although that output looks like what you should see if you try to debug applying it when it's already applied?

There are two things the patch does:

1. Before the patch setting the filter to remote still showed all the local IP addresses. It should filter correctly with the patch.
2. Before patching the local filter excluded traffic that was just within the local subnet so that included traffic from clients to the firewall itself. Those now show.

If the connections do not show in the output from rate at all for some reason then the patch won't help.

Steve

[jrey]

@stephenw10

Not sure what to tell you - this is the only patch applied (once) and since reverted (once) - and there are no other patches on the beta.

I'll try again after the RC. It's no big deal I don't sit on these screens monitoring traffic. I was only poking because of the beta.

[stephenw10]

Strange. It reverts and applies cleanly everywhere I've tried it.
Let's revisit in RC.

[jrey]

@stephenw10

Strange indeed. So I made it work on this system / beta 23.09.b.20231023.1701

Not sure why, as the original patch as provided indicated at least by the system the patch applied.

1. I downloaded * the original version of the inc file being patched to another machine
2. modified the patch provided removing the change at line 20 and the one at the end referencing line 208
   This leaving only the two actual changes of significance in the diff - so the patch now contains only this before applying
   

3 Applied that modified patch (still apply OK, ie Revert Button appears, apply says good)
4 revisit the graph, surprise the IPs hang around longer and the list does not appear mostly empty.
5 download * the now patched inc file to other machine
6 revert the patch, confirm the graph has no IPs

So the patch itself does work
Now for the two files I downloaded. (the one at step 1 the original and step 5 the patched)
run a diff on these and get

remember I modified the original patch before applying
the difference in this new diff (the change reported at line 20 is back the same as the original, but the change regarding the end of file (line 208) is not.

So strange indeed..

When the RC comes out, I'll let it settle in a while and try this all again. starting with the original patch, and then following through with modifying it and trying again if needed.

[jrey]

@jrey
In installed the RC without any patch applied,

IP list on graph was again mostly empty
applied the patch (my modified one) as described above.

IP's are listing fine again..

I'll go back after a bit of lunch and try the original patch, see if that is any different or works. (because that is/was likely something else) as the actual real lines needed to make it go are the same.