Proper procedure for adding a NIC kernel module? (qlnxe)

[GeorgePatches]

@stephenw10 said in Proper procedure for adding a NIC kernel module? (qlnxe):

What is that NIC exactly?

My speculation was correct, it is a Qlogic FastlinQ QL41132HLCU exactly.

[kprovost]

@stephenw10 I've not done any detailed digging, but there's been at least one bug fix in dump_iface() not too long ago to fix similar crashes:

commit 7d48224073ce14f0dd3db2d4e96876ac928b52f2
Author: Bjoern A. Zeeb <bz@FreeBSD.org>
Date:   Sat Sep 30 15:11:57 2023 +0000

    netlink: fix accessing freed memory

    The check for if_addrlen in dump_iface() is not sufficient to determine
    if we still have a valid if_addr.  Rather than directly accessing if_addr
    check the STAILQ (for the first entry).
    This avoids panics when destroying cloned interfaces as experienced with
    net80211 wlan ones.

    Sponsored by:   The FreeBSD Foundation
    MFC after:      3 days
    Reviewed by:    jhibbits (earlier version), kp
    Differential Revision: https://reviews.freebsd.org/D42027

It's certainly worth testing a 2.8 snapshot before we dig deeper.

[GeorgePatches]

@kprovost said in Proper procedure for adding a NIC kernel module? (qlnxe):

It's certainly worth testing a 2.8 snapshot before we dig deeper.

Would that fix be in the latest PF+? This is a production machine with lots of work happening, but I'm poking my management chain about paying for support.

[kprovost]

@GeorgePatches That particular patch is in 24.03, yes.

[stephenw10]

Hmm, I wonder if we can do something to avoid that bug as a test.

[GeorgePatches]

@stephenw10 Hmmmmm, a thought is that it blew up on the dummynet code. I can try ripping the limiters out and see it doesn't blow up.

[GeorgePatches]

This thought was wrong, it blew up exactly the same without limiters and the dummynet modules not loaded.

[stephenw10]

Well one thing ruled out I guess!

[GeorgePatches]

There's no easy way to like try a 2.8 snap and then roll back to 2.7.2, right? You can do that with PF+, if I understand the bootloader thing correctly?

I ask because management has approved our initial request for a support contract. We're currently waiting on a quote and then actual approval and purchasing. I'm ok putting a pin in this until it's easier to test a snap and roll back. This card is a nice to have, we're currently "doing fine" with our LAGG'd gigabit links.

[stephenw10]

You can manually create ZFS snapshots at the CLI in CE, assuming you are running ZFS. However there are no public 2.8-dev snapshots yet.