Dns forwarde domain override did not save

Antibiotic

Hello, DNS forwarder did not save any options in domain override. I want to do like this:

Domain = 168.192.in-addr.arpa
IP address = 192.168.20.1
Source IP = Empty
Description = Reverse forwarder

But nothing to save. I want to use forwarding for one of pfSense interface with Wireguard client and may rule redirect from port 53 unbound to port 5353. All working except this. Any ideas?

Pfsense 24.11

Antibiotic

@Antibiotic said in Dns forwarde domain override did not save:

168.192.in-addr.arpa

Hello, is it a bug? ANYONE

patient0

@Antibiotic there was a thread about it but I can find it anymore. But there's an open bug report that sound like it may be your issue:

Unable to change domain overrides in DNSMasq

The corresponding fix seems easy enough for a patch:

https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/aac5bb5d396a1f1b18d59a532ad262a4d1085a40/diff

diff --git a/src/usr/local/pfSense/include/www/services_dnsmasq.inc b/src/usr/local/pfSense/include/www/services_dnsmasq.inc
index 9777298f1b..23659ad9aa 100644
--- a/src/usr/local/pfSense/include/www/services_dnsmasq.inc
+++ b/src/usr/local/pfSense/include/www/services_dnsmasq.inc
@@ -457,9 +457,9 @@ function saveDomainOverride($post, $id, $json=false) {
         $doment['descr'] = $post['descr'];
 
         if (isset($id) && config_get_path("dnsmasq/domainoverrides/{$id}") && ($id != -1)) {
-            config_get_path("dnsmasq/domainoverrides/{$id}", $doment);
+            config_set_path("dnsmasq/domainoverrides/{$id}", $doment);
         } else {
-            config_get_path('dnsmasq/domainoverrides/', $doment);
+            config_set_path('dnsmasq/domainoverrides/', $doment);
         }
 
         $retval = services_dnsmasq_configure();

Antibiotic

@patient0 Oh , thank you buddy. This patch was applied and everything is working now)))

Antibiotic

@patient0 But, where did you get this? By this link not as a patch, like you present me.

patient0

@Antibiotic the link just above the patch is the link to the diff (https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/aac5bb5d396a1f1b18d59a532ad262a4d1085a40/diff)

Or on the website of the first link there an comment Applied in changeset aac5bb5d396a1f1b18d59a532ad262a4d1085a40 which leads to the same page.

Antibiotic

@patient0 said in Dns forwarde domain override did not save:

https://redmine.pfsense.org/projects/pfsense/repository/2/revisions/aac5bb5d396a1f1b18d59a532ad262a4d1085a40/diff

Ah understood need to export in Unified diff