Revert custom System Patch for console widget refresh?
-
For my 2100 I applied the custom patch for console widget refresh described here: https://forum.netgate.com/topic/190824/cpu-load-on-1100/23?_=1736456846601
Should I first revert this custom patch before applying all the recommended patches in System Patches 2.2.20?
It doesn't appear from the 2.2.20 patch descriptions that this console widget refresh issue has been addressed. If that's the case, should the same custom patch be re-applied again?
-
@terryzb In general I'd expect it should not matter unless another patch modifies that same file(s) in that same area of code and thus they conflict. Which is probably unlikely if they didn't include the changes in the Patches package.
If it does conflict I'd expect the second should fail to match/install if the contents of the file differ from what is expected.
That said it should also not hurt to remove it and re-apply after.
IOW patches are replacing/adding specific lines in the file, not the entire file.
-
You shouldn't need to revert or remove a patch before upgrading the package. It shouldn't need to be re-applied. Though in this case the change in behaviour there was to revert that patch. The same is true, you shouldn't need to do anything special before upgrading.
-
Thank you very much @stephenw10 and @SteveITS
-
@stephenw10 Just to follow up on this, I applied all recommended patches then rebooted the 2100. It took a good 15 minutes to completely finish. When viewing the dashboard, the CPU now varies between 40%-98%. System->Patches shows the custom Console revert is still applied.
-
It shows as applied or reverted?
That is a patch that has to be reverted to go back to the previous widget update behaviour.
-
@stephenw10
Looks to me like it's still applied.
So you're saying I should in fact revert this patch? Sorry, I must've misunderstood your previous post.
-
Yes revert that patch to go back the previous widget update behaviour.
That patch is what changed it to the new behaviour in 24.11.
-
@stephenw10
Thank you Stephen. I reverted and deleted the patch and CPU is now down to 21%-29%. -
Nice. Significant!
Yeah we are looking at how best to handle this going forward.
