Do I Need to Revert Patches Before Upgrading pfSense?
-
Hello,
When using the "Patches" package in pfSense, do I need to revert applied patches before upgrading to a new release?
If not, will previously applied patches still appear in the patch list after the upgrade if they have already been incorporated into the new version?
I ask because I noticed the line: "After upgrading, do not revert a patch if the changes from the patch were included in the upgrade. This will remove the changes, which is unlikely to be helpful."
This seems to suggest that patches included in the upgrade remain in place.Any clarification would be greatly appreciated!
Thanks!
-
@leeroy Normally, patches are included in the later versions of pfSense and those files are just overwritten.
Typically then the list of patches does not include patches for old versions, only ones that apply to the new version. (this list is updated when the patches package is updated)
However since it's possible to add a custom patch, they mean, don't apply a custom patch, then replace the file on disk, then attempt to revert the custom patch.
IOW the patches here just replace certain lines of code in various PHP files. If the file was changed, the lines of code no longer match up.
-
@leeroy said in Do I Need to Revert Patches Before Upgrading pfSense?:
"After upgrading, do not revert a patch if the changes from the patch were included in the upgrade. This will remove the changes, which is unlikely to be helpful."
This would be valid for patches you've added yourself (manually), before the pfSense upgrade, and were not yet included in this upgrade.
So, these patches still "apply".
If your manually entered patches doesn't apply anymore, this means that this patch is probably ( ! ) solved.These :
will be gone, as a new pfSense version will also receive a new System patches package, with less, or even no patches to apply, as the new pfSEnse version will include these corrections (as the patches are (one of) the reasons why the new pfSense was released !)
-
-
We don’t have any custom packages, so this should be fine. Ultimately, I’d prefer not to manage these packages, and the fact that they will automatically disappear as they’re incorporated into future releases is ideal.
We’re experiencing a couple of odd issues with KEA and logging, and I noticed a fix in there that seems relevant. I’ll test these first before filing a bug.
-
@leeroy said in Do I Need to Revert Patches Before Upgrading pfSense?:
We don’t have any custom packages
Make :
an exception.
It's made by Netgate, for pfSense. Even if you don't think you need it, you need it. Probably because Netgate knows more about pfSense then we do
