ARPWatch typo in subject of email notifications

Popolou

Must be a 2.8.0 thing, not seeing this with 2.7.2.

stephenw10

Hmm, odd. Do you also see that logged locally?

stephenw10

Oh I see only in the first part of the subject line:

fw1stevew.lan - Arpwatch Notification : new station (fw1.stevew.lan)

stephenw10

I see the problem. I think it's always been like that, nothing has changed there. For a while at least.

Patch incoming....

bfloeagle

@stephenw10 Thank you!

stephenw10

It's a one line patch so should be safe enough to add manually if anyone wants to try it:

diff --git a/net-mgmt/pfSense-pkg-arpwatch/files/usr/local/pkg/arpwatch.inc b/net-mgmt/pfSense-pkg-arpwatch/files/usr/local/pkg/arpwatch.inc
index 247cc3c4e1f4baf6325c22ab778d64c3bdf8afc2..e4c2f2b9e72d96a573c7ebb3ce52c01c278265ab 100644
--- a/net-mgmt/pfSense-pkg-arpwatch/files/usr/local/pkg/arpwatch.inc
+++ b/net-mgmt/pfSense-pkg-arpwatch/files/usr/local/pkg/arpwatch.inc
@@ -239,7 +239,7 @@ if ((false !== $message) && ((false === strpos($message, ': Cron ')) ||
 	$message = preg_replace('/^To: .*$/m', '', $message);
 	$message = preg_replace('/^Subject: .*$/m', '', $message);
 	$message = preg_replace("/^(\n){4}/", '', $message);
-	$send_subject = config_get_path('system/hostname') . config_get_path('system/domain') . " - Arpwatch Notification : {$subject[1]}";
+	$send_subject = config_get_path('system/hostname') . "." . config_get_path('system/domain') . " - Arpwatch Notification : {$subject[1]}";
 
 	send_smtp_message($message, $send_subject);
 	if (function_exists('notify_via_telegram')) {

https://redmine.pfsense.org/issues/16410

bfloeagle

This post is deleted!

stephenw10

It's only a typo so it's pretty low priority but it's been merged so it will be in the 25.11 and the next CE.
https://github.com/pfsense/FreeBSD-ports/commit/c43d479574f820dada0ff8b2f788fca587b85d61

dennypage

@stephenw10 Take a look at ANDwatch as an alternative...

stephenw10

Yup, looks good.

OP here asked about the typo but then deleted then post.