There has been an error creating the graphs.
-
I was running 2.0-BETA1 built on Sat Feb 13 13:23:57 EST 2010 when I posted that. I just checked and I get the same error with 2.0-BETA1 built on Sun Feb 14 15:12:58 EST 2010.
-
Ticket #1942 in the Alpha Alpha version.
I created ticket #330 for this in the Beta for the Code-Red theme but that only applies to the Traffic and Packets Graph. Geeknik's error is on the System tab, I've tried every theme yet cant find one that gives an error on the System Tab.
Theme Code-Red's fix for this involves editing the following:
/usr/local/www/themes/code-red/rrdcolors.inc.php
Change lines 33,34,35,36
From:
$colortrafficup = "666666";
$colortrafficdown = "990000";
$colorpacketsup = "666666";
$colorpacketsdown = "990000";Change to:
$colortrafficup = array("666666", "CCCCCC");
$colortrafficdown = array("666666", "CCCCCC");
$colorpacketsup = array("666666", "CCCCCC");
$colorpacketsdown = array("666666", "CCCCCC"); -
That sounds familiar but I thought it was already fixed.
jimp…. I think you posted this change into the git..
file /usr/local/www/status_rrd_graph_img.php
at about line 677
missing initialize of $t = 0This Fixed the Queue Graph problem... but if you look down a few more lines in the code.. the same change needs to be made for the QueueDrops.
Can you post it into the git?
Jim
-
Can you be a little more specific about where exactly that change is? Perhaps some context around it or a diff?
I can make the change if I know where it's really needed, rather than guessing.
-
@onhel:
I created ticket #330 for this in the Beta for the Code-Red theme but that only applies to the Traffic and Packets Graph. Geeknik's error is on the System tab, I've tried every theme yet cant find one that gives an error on the System Tab.
I just committed that fix.
-
Unable to view the Memory RRD graph:
Are you using "the_wall" as your theme, by chance? If so, it should work after the commit I just did. I found it was missing the color definition for the memory graph.
-
Can you be a little more specific about where exactly that change is? Perhaps some context around it or a diff?
I can make the change if I know where it's really needed, rather than guessing.
Sorry about that… here is the code.. I put my line in red.. and the one you did a few weeks ago in green...
BTW... I love you book that you and Chris wrote... would you happen to have something that explains how to get started with git? I would like to contribute fixes..
Let me know.
Jim
elseif((strstr($curdatabase, "-queues.rrd")) && (file_exists("$rrddbpath$curdatabase"))) {
/* define graphcmd for queue stats /
$graphcmd = "$rrdtool graph $rrdtmppath$curdatabase-$interval.png ";
$graphcmd .= "--start -$seconds -e -$average ";
$graphcmd .= "--vertical-label "bits/sec" ";
$graphcmd .= "--color SHADEA#eeeeee --color SHADEB#eeeeee ";
$graphcmd .= "--title "hostname- {$prettydb} - {$hperiod} - {$havg} average" ";
$graphcmd .= "--height 200 --width 620 -x "$scale" ";
if ($altq) {
$a_queues =& $altq->get_queue_list();
$t = 0;
} else {
$a_queues = array();
$i = 0;
$t = 0;
}
foreach ($a_queues as $name => $q) {
$color = "$colorqueuesup[$t]";
if($t > 0) { $stack = ":STACK"; }
$graphcmd .= "DEF:"$name=$rrddbpath$curdatabase:$name:AVERAGE" ";
$graphcmd .= "CDEF:"$name-bytes_out=$name,0,$speedlimit,LIMIT,UN,0,$name,IF" ";
$graphcmd .= "CDEF:"$name-bits_out=$name-bytes_out,8," ";
$graphcmd .= "$AREA:"$name-bits_out#${color}:$name" ";
$t++;
if($t > 7) { $t = 0; }
}
$graphcmd .= "COMMENT:"\n" ";
$graphcmd .= "COMMENT:"\t\t\t\t\t\t\t\t\t\t\t\t\tdate +\"%b %d %H\:%M\:%S %Y\"" ";
}
elseif((strstr($curdatabase, "-queuedrops.rrd")) && (file_exists("$rrddbpath$curdatabase"))) {
/* define graphcmd for queuedrop stats /
$graphcmd = "$rrdtool graph $rrdtmppath$curdatabase-$interval.png ";
$graphcmd .= "–start -$seconds -e -$average ";
$graphcmd .= "--vertical-label "drops / sec" ";
$graphcmd .= "--color SHADEA#eeeeee --color SHADEB#eeeeee ";
$graphcmd .= "--title "hostname- {$prettydb} - {$hperiod} - {$havg} average" ";
$graphcmd .= "--height 200 --width 620 -x "$scale" ";
if ($altq) {
$a_queues =& $altq->get_queue_list();
$t = 0; // Added this.. jwr
} else {
$a_queues = array();
$i = 0;
$t = 0;
}
foreach ($a_queues as $name => $q) {
$color = "$colorqueuesdropup[$t]";
if($t > 0) { $stack = ":STACK"; }
$graphcmd .= "DEF:"$name=$rrddbpath$curdatabase:$name:AVERAGE" ";
$graphcmd .= "CDEF:"$name-bytes_out=$name,0,$speedlimit,LIMIT,UN,0,$name,IF" ";
$graphcmd .= "CDEF:"$name-bits_out=$name-bytes_out,8," ";
$graphcmd .= "CDEF:"$name-bits_out_neg=$name-bits_out,$multiplier,*" ";
$graphcmd .= "$AREA:"$name-bits_out_neg#${color}:$name" ";
$t++;
if($t > 7) { $t = 0; }
}
$graphcmd .= "COMMENT:"\n" ";
$graphcmd .= "COMMENT:"\t\t\t\t\t\t\t\t\t\t\t\t\tdate +\"%b %d %H\:%M\:%S %Y\"" ";
} -
I committed the fix. (Actually I found where you were talking about just as you posted this – good timing :-)
Here is a doc on working with git:
http://devwiki.pfsense.org/GitWorkflow
-
Sorry Jimp, the code should be changed to this for the Code-Red Theme, dont know what happened with the cut and paste.
$colortrafficup = array("666666", "CCCCCC");
$colortrafficdown = array("990000", "CC0000");
$colorpacketsup = array("666666", "CCCCCC");
$colorpacketsdown = "array("990000", "CC0000"); -
Whoops. Should be fixed now.
