Country Block

netritious

Nice package and great addition to pfSense!

I did have some trouble with the package starting, and after a little research found the problem in execute.sh:

This line:

export t=`grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]'`

I changed to:

export t=`grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]\{1,2\}'`

The service would fail to start otherwise. Running execute.sh (/usr/local/etc/rc.d/countryblock.sh) manually from CLI produced the error:

export: 0: bad variable name

and that's because the line number is actually 10 in my /tmp/rules.debug, but due to the regular expression grep was returning 1\n0 (one newline zero), so $t was being assigned "0" instead of "10."

EDIT: Are my changes to execute.sh persistent? Eg, if I reboot will I need to edit again?

On another note the countryipblock.net web site states that no automated process may be used to download the list and may not be redistributed. (see Policies Affecting Access and Use of the Website and Database) Not that it's really any of my business and I am not affiliated with countryipblocks.net, but I thought I would mention it since it's not exactly visible on the web site unless you look for it. I don't know if this affects the package or not. (I hope not!)

Anyway, thanks Tom for this awesome package!

-Rich

motersho

Nice package and great addition to pfSense!

I did have some trouble with the package starting, and after a little research found the problem in execute.sh:

This line:
Code:
export t=grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]'

I changed to:
Code:
export t=grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]\{1,2\}'

The service would fail to start otherwise. Running execute.sh (/usr/local/etc/rc.d/countryblock.sh) manually from CLI produced the error:

Code:
export: 0: bad variable name

and that's because the line number is actually 10 in my /tmp/rules.debug, but due to the regular expression grep was returning 1\n0 (one newline zero), so $t was being assigned "0" instead of "10."

EDIT: Are my changes to execute.sh persistent? Eg, if I reboot will I need to edit again?

On another note the countryipblock.net web site states that no automated process may be used to download the list and may not be redistributed. (see Policies Affecting Access and Use of the Website and Database) Not that it's really any of my business and I am not affiliated with countryipblocks.net, but I thought I would mention it since it's not exactly visible on the web site unless you look for it. I don't know if this affects the package or not. (I hope not!)

Anyway, thanks Tom for this awesome package!

-Rich

I had the same issue as netritious and his fix worked for me.

NoahVail

Same issue as as motersho and netritious, the grep rewrite fixed me as well.

VERY grateful. You got me past a head banging problem.

NV

tommyboy180

@netritious:

Nice package and great addition to pfSense!

I did have some trouble with the package starting, and after a little research found the problem in execute.sh:

This line:
export t=`grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]'`
I changed to:
export t=`grep -n 'User Aliases' /tmp/rules.debug |grep -o '[0-9]\{1,2\}'`
The service would fail to start otherwise. Running execute.sh (/usr/local/etc/rc.d/countryblock.sh) manually from CLI produced the error:
export: 0: bad variable name
and that's because the line number is actually 10 in my /tmp/rules.debug, but due to the regular expression grep was returning 1\n0 (one newline zero), so $t was being assigned "0" instead of "10."

EDIT: Are my changes to execute.sh persistent? Eg, if I reboot will I need to edit again?

On another note the countryipblock.net web site states that no automated process may be used to download the list and may not be redistributed. (see Policies Affecting Access and Use of the Website and Database) Not that it's really any of my business and I am not affiliated with countryipblocks.net, but I thought I would mention it since it's not exactly visible on the web site unless you look for it. I don't know if this affects the package or not. (I hope not!)

Anyway, thanks Tom for this awesome package!

-Rich

Excellent! I have been working on some fixes and you have saved me some time. This will be in my next commit. Your changes to the script will be persistent.

Thank you for pointing out the notice that I was not aware of. I will do some work in the next couple of days (hopefully) and make this package independent.

Thanks Rich!

tommyboy180

New Version released. Version 1.3 is out!

Fixed GUI menu tile images
Working on pfsense BETA 2 x86 and x64 now
Fixed a rare glitch - Thank you netritious!
Added a whitelist feature
also removed 'bogon' from the list to prevent this ->http://forum.pfsense.org/index.php/topic,26226.0.html from happening

Thanks for your support all.

Supermule

/tmp/rules.debug:117: cannot load "/usr/local/www/packages/countryblock/countries-white.txt": No such file or directory

I get this after update….

Supermule

Whitelist.php not found….. Who the hell has fucked up this package??? GRRRRRRRRRRRR!!!!#¤%&

tommyboy180

Hey Supermule,
I think you grabbed the update a little to fast. When I updated the package two files were not uploaded right away. Completely uninstall the package and re-install it for me please.

I think you will be pleased.

DigitalJer

Looking great tommyboy180!

ty :)

chpalmer

/tmp/rules.debug:90: cannot load "/usr/local/www/packages/countryblock/countries-white.txt": No such file or directory still here…

tommyboy180

Uninstall package, Reboot box, reinstall package and enjoy.

Supermule

Still there….........

Current Status = NOT running
/tmp/rules.debug:112: cannot load "/usr/local/www/packages/countryblock/countries-white.txt": No such file or directory

:-\

Supermule

But after I click the whitelist icon, do nothing and then returns to the "main" page, it works…....:?

tommyboy180

I have tested and tested today. I can't replicate your issue.

I started on a fresh install and everything is fine. I tested on Beta 2 and 1.2.3.

Supermule

Does it create the whitelist pr default or is it allready in the package before it starts?

tommyboy180

It touches it so the file is created when the package is installed.

Supermule

Can you verify that it actually does that??

I had to do it manually.

DigitalJer

I had the same error, and persistence paid off. I don't recall if it started working after a reboot, or 'Commit Countries" did it, but keep trying… Not very helpful, I know :( ...but in the end it's OK.

chpalmer

@DigitalJer:

I had the same error, and persistence paid off. I don't recall if it started working after a reboot, or 'Commit Countries" did it, but keep trying… Not very helpful, I know :( ...but in the end it's OK.

I clicked through the "whitelist" and was finally able to make it work.

:)

After I updated everything worked fine. I added some entries to the whitelist and then removed them latter. I could not get the package to start again after that. I removed the package numerous times and rebooted, and contuniued to get the same error as everyone is listing. I finally added those IP's back to the whitelist and I was able to get it to start up again.

I believe you can reproduce this issue by installing the package.

Adding some IP's to the white list.

Remove the IP's

Uninstall the package

Then reinstall it.