The hostname cannot end with a hyphen

[townsenk]

On services:DHCP static mapping, If you enter a Hostname with a Hyphen anywhere it will reject it displaying this message

"The hostname cannot end with a hyphen according to RFC952"

I can understand why it would reject a name such as "clientpc-" but should it reject names like "client-pc" as well? I thought the latter was acceptable.

Thank You

[Efonnes]

I'll take a look at it.  Probably has an improperly formatted regular expression for doing the match.  I recall seeing the commit that did this, but didn't really think anything of it at the time.

[Efonnes]

Fixed

If you want to apply the change yourself now, make the change shown here: https://rcs.pfsense.org/projects/pfsense/repos/mainline/commits/392687e5633a663c1297363ff2d5d8e8f15298d7

[townsenk]

Thank You, I made the changes and it resolved the issue.