Squid cachemgr

[dvserg]

2 marcelloc

Need fix squid.inc line 1044 for cachemgr options (func function squid_resync_nac):

EOD;

	$settings_ch = $config['installedpackages']['squidcache']['config'][0];
	if(!empty($settings_ch['ext_cachemanager'])) {
		$extmgr = explode(";", ($settings_ch['ext_cachemanager']));
		$count = 1;
		$conf .= "\n# Allow external cache managers\n";
//    $conf .= "acl ext_manager src ".$settings['ext_cachemanager']."\n";
		foreach ($extmgr as $mgr) {
			$conf .= "acl ext_manager_{$count} src {$mgr}\n" ;
			$conf .= "http_access allow manager ext_manager_{$count}\n";
			$count += 1;
		}
	}

	$conf .= <<

[marcelloc]

Thanks!

The cachemgr option is not on nac tab.

I'll fix it.

[marcelloc]

Is the a reason to create one acl for each cache manager?

# Allow external cache managers
acl ext_manager_1 src 192.168.52.75
http_access allow manager ext_manager_1
acl ext_manager_2 src 192.168.63.74
http_access allow manager ext_manager_2

Isn't this a better option?

# Allow external cache managers
acl ext_manager src 192.168.52.75
acl ext_manager src 192.168.63.74
http_access allow manager ext_manager

EOD;

	if (is_array($config['installedpackages']['squidcache'])){
		$settings_ch = $config['installedpackages']['squidcache']['config'][0];
		if(!empty($settings_ch['ext_cachemanager'])) {
	  		$extmgr = explode(";", ($settings_ch['ext_cachemanager']));
    		$conf .= "\n# Allow external cache managers\n";
	 		foreach ($extmgr as $mgr) {
    			$conf .= "acl ext_manager src {$mgr}\n";
	 			}
	 		$conf .= "http_access allow manager ext_manager\n";
			}
		}

  $conf .= <<

[dvserg]

I do not see the difference, if worked. I just looked up the error in the code.

[marcelloc]

@dvserg:

I do not see the difference, if worked. I just looked up the error in the code.

Ok, I've published the new code. Thanks for the fix.

[dvserg]

@marcelloc:

@dvserg:

I do not see the difference, if worked. I just looked up the error in the code.

Ok, I've published the new code. Thanks for the fix.

Thanks!
New proxy - good job!