Bug in IPSec Dashboard widget?

[rcfa]

It seems suddently the IPsec widget gobbles up all widgets that are below it, and the look and act as if they were sub-widgets of the IPSec widget.

Note the narrower title bars of the widgets following, and the lack of a white divider area.

I deleted the IPSec widget, which seemingly deletes all the "subwidgets", too. But these then show up like normal upon a save. The moment I add the IPSec widget again, it's back to this odd behavior. This is rather new. I'm currently on build

2.1-DEVELOPMENT (amd64)
built on Sat May 26 23:51:01 EDT 2012
FreeBSD 8.3-RELEASE-p1

Anyone else noticed this?

[rcfa]

While on the subject: there also seems to be a formatting error, since the columns between labels and content in the tunnels tab don't line up.
Also, if there are three tabs, why are they not taking up the full width of the widget? Would look cleaner.

I know, it's nit-picking, but since there's a bug in the widget code I though maybe this can be cleaned up in the same go-around.


[jimp]

I've been working on that widget and I hadn't noticed the first behavior, but I'll check it over again now. I probably just missed a closing tag somewhere.

As for the tab width, none of our tabs fill the whole width, they are all only as big as the text within them requires, to expand their width would be inconsistent with the rest of the UI.

[jimp]

Yep, just a missing closing tag..
https://github.com/bsdperimeter/pfsense/commit/454ea767609ea3e679e0de4ec795532e66c7ce47

[rcfa]

@jimp:

I've been working on that widget and I hadn't noticed the first behavior, but I'll check it over again now. I probably just missed a closing tag somewhere.

Figured something like that, but since I don't know the code I thought better describe the issue than muse about it's cause ;)

@jimp:

As for the tab width, none of our tabs fill the whole width, they are all only as big as the text within them requires, to expand their width would be inconsistent with the rest of the UI.

You're right. I guess on the full-width pages, with e.g. three tabs, it would ridiculous to divide the space into three huge tabs, so that never caught my eye, because there it looks right. On the other hand three tabs and a stubby bit of space left over, seems to scream to divide the space among all tabs and even it out.
But I guess being consistent is better, even if it looks a bit odd in this case.

Still wonder though what's the issue with the columns not lining up properly between titles and the list.
Are these separate tables? Because a single table with a row of title cells and N-rows of list cells, I wouldn't expect to behave like that, unless Firefox is a bit wonky there.

[jimp]

It's not a table there, but a bunch of div tags, sometimes they need some minor adjustments of a pixel or two to line up. Though they lined up for me when I looked it over.

[rcfa]

@jimp:

It's not a table there, but a bunch of div tags, sometimes they need some minor adjustments of a pixel or two to line up. Though they lined up for me when I looked it over.

Maybe funky stuff happens when the description text doesn't naturally fit into the provided space? The destination host name is somewhat long in my case, as is the description text.