Build script commit?

[rcfa]

I just had an idea, maybe it's cookie, but here it goes:

If the build-script would commit a change to github, e.g. an include file update with the build-date or something like that, then just looking at the github page would in once glance show which changes are included in a build: everything below the latest build-script commit line would be included, everything above, would not.
Also, looking at the committed "code", one could also identify the precise build by it's date.

[Efonnes]

The file /etc/version.lastcommit in the built images contains the info you are looking for.  I suppose it might be useful to upload this file along with the images for reference.  Making commits for the built images would just leave a big mess in the commit history.

[rcfa]

@Efonne:

Refer to /etc/version.lastcommit

Sure, but that's sort of the opposite. This helps you decide what's in a build that's already installed, it doesn't help you decide if you should install a particular build, because you're waiting for a specific commit to be included.

But speaking of which…
...why do
/etc/version_kernel
/etc/version_base
contain "8.1"?? I thought we're on 8.3?

[Efonnes]

I didn't think you would actually see the message so soon. :)  I added a bit more to my reply before you replied to it.

[rcfa]

No harm done ;)

Anything that makes it easier to see the cut-off is fine by me…
...or upload a zero-byte length file that has a name like e.g.

LastCommit.0551a524d4486a5fdc934c371dcb073337d4b7f1

That way one doesn't have to download the file and look at its contents, one can simply look at the file listing and deduce from that what's in the build.

Many ways to skin the cat ;)

[dhatz]

@rcfa:

…why do
/etc/version_kernel
/etc/version_base
contain "8.1"?? I thought we're on 8.3?

Apparently Seth fixed the latter, but not the former:

https://raw.github.com/bsdperimeter/pfsense/117f8e6f0cf342d62188d192fe0c48d7ae172855/etc/version_kernel still reads 8.1

[rcfa]

@dhatz:

@rcfa:

…why do
/etc/version_kernel
/etc/version_base
contain "8.1"?? I thought we're on 8.3?

Apparently Seth fixed the latter, but not the former:

https://raw.github.com/bsdperimeter/pfsense/117f8e6f0cf342d62188d192fe0c48d7ae172855/etc/version_kernel still reads 8.1

To me it's seems somewhat odd that these are hardcoded anyway. We have uname that spits out the correct thing, so that means that somewhere else these values are already likely #define-ed, so why not use that, and never have to deal with this again?

[dhatz]

Just a quick reminder that file /etc/version_kernel on 2.1-BETA0 23-Jun-2012 still reads 8.1. Shouldn't this be 8.3 ?