Possible bug in "Group Manager"



  • I believe there maybe a tiny bug in the group manager. I'm on the latest 2.1-BETA0 (i386) (built on Fri Aug 17), I get the below error.

    To recreate go to:

    System > User Manager > Groups > Add Group button

    Error displayed within Not Members and Members boxes:

    "array null given in /usr/local/www/system_groupmanager.php on line 296 Warning: in_array() expects parameter 2 to be array"

    There maybe more to the error but it's jumbled for me…

    Thanks



  • I am running 2.1-BETA0 (i386) built on Mon Aug 6 09:38:58 EDT 2012 and this is not happening for me.


  • Rebel Alliance Developer Netgate

    It's not happening to me either but I can see how it could in the code, added a safety check before that bit would run so it can't result in an error.



  • I only started with pfsense a few days ago so maybe it wouldn't be something others ran into if they started from an earlier build. Thanks though for looking into it!  :)



  • I think I spoke too soon…. I checked after upgrading to the latest 2.1 version last night and instead of seeing the error in both members and non-members, NOW it's only in the Members section. The part of the error in that field I can see is:

    
    be array, null given in /usr/local/www/system_groupmanager.php on line 322 Warning: in_array() expects parameter 2 to be array, null given in /usr/local/www/system_groupmanager.php
    
    

    Again, this WAS happening in both fields but I see it's still an issue in Members field.

    Thanks and let me know if screenshots necessary



  • The safety check was added to the first field only. I just made a patch that adds it to the second field as well.



  • Thank you for taking the time to investigate and patch. You guys are great!


Locked