D-Link DGE-528T PCI card

mastrboy

I just bought 2 D-Link DGE-528T gbit cards, and checked the HCL for freebsd 6.2 first, which said they would be supported (http://www.freebsd.org/cgi/man.cgi?query=re&sektion=4&manpath=FreeBSD+6.2-RELEASE)

But to my demise they were not detected by pfsense, but i found a bug report and patch for fixing it:
http://www.freebsd.org/cgi/query-pr.cgi?pr=112774

The question is, could this patch be added to the pfsense kernel or do you not integrate patches like these?

dotdash

That's a patch for 6.1. Are you running 1.0.1 or 1.2beta1? 1.2 is based on 6.2, so try the beta if you haven't already.
edit: wait, you died 'cause the NIC didn't come up? http://dictionary.reference.com/browse/demise
;D

mastrboy

back from the dead ;D

:P the english is not the best i guess, i tried to come up with a good word to indicate that i was displeased :P

but to the issue, i already use 1.2 beta.

and if you look at the bug report under How-To-Repeat section, there is a statement for 6.2:

Add a D-Link DGE-528T (hardware rev. B1) in a FreeBSD machine under 6.2-RELEASE. Boot. Notice the card is not detected.

and even if the patch is for 6.1, for 6.2 the lines to add should be the same, just on some other line if the file has changed any from 6.1 - 6.2

Edit: to make sure i checked out the 6.2 kernel sources for this, and it's not added :(

i did a diff on the source after the changes, and it looks the same as in the bug report:


[root@freebsd /usr/src/sys/dev/re]# diff -up orig_if_re.c if_re.c

--- orig_if_re.c        Fri Jun  8 11:04:55 2007
+++ if_re.c     Fri Jun  8 11:05:25 2007
@@ -168,6 +168,8 @@ MODULE_DEPEND(re, miibus, 1, 1, 1);
 static struct rl_type re_devs[] = {
        { DLINK_VENDORID, DLINK_DEVICEID_528T, RL_HWREV_8169S,
                "D-Link DGE-528(T) Gigabit Ethernet Adapter" },
+        { DLINK_VENDORID, DLINK_DEVICEID_528T, RL_HWREV_8169_8110SB,
+               "D-Link DGE-528(T) Rev.B1 Gigabit Ethernet Adapter" },
        { RT_VENDORID, RT_DEVICEID_8139, RL_HWREV_8139CPLUS,
                "RealTek 8139C+ 10/100BaseTX" },
        { RT_VENDORID, RT_DEVICEID_8101E, RL_HWREV_8101E,

[root@freebsd /usr/src/sys/dev/re]# uname -a
FreeBSD freebsd.xxxxxx.no 6.2-RELEASE FreeBSD 6.2-RELEASE #0: 
Fri Jan 12 10:40:27 UTC 2007     root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386

i also submitted it to the pfsense cvs trac as a feature request

mastrboy

yeaa, it got included in the pfsense kernel: http://cvstrac.pfsense.com/tktview?tn=1345