System_reboot_cleanup error

jcyr · Feb 17, 2013, 1:27 AM

On every reboot, I get:

Warning: Invalid argument supplied for foreach() in /etc/inc/system.inc on line 1351
Stopping package Cron…done.

I do not use portals.

2.1-BETA1 (i386)
built on Sat Feb 16 10:53:05 EST 2013

phil.davis · Feb 17, 2013, 2:44 PM

I added a comment to this commit - https://github.com/bsdperimeter/pfsense/commit/62f20eab8855915bc87c23dd13025e922dc1606d
The loop needs an extra check first to see if the array exists.

jcyr · Feb 17, 2013, 6:21 PM

Hmm… Seems odd that you'd commit code that you know is broken and that affects everybody!

Reason given: Can't test it!!!

phil.davis · Feb 18, 2013, 12:58 PM

@jcyr:

Hmm… Seems odd that you'd commit code that you know is broken and that affects everybody!

Reason given: Can't test it!!!

I'm not sure I understand what you are saying. Obviously a little mixup here - I added a comment to someone else's commit. The person who submitted the code would have tested it on their system, it worked on systems that had CARP settings. My comment was just that I could see where to fix the code, but was not near my test system to make the change and verify it worked - I definitely don't do theoretical fixes in GitHub without testing them:)
Anyway, the extra check has now been committed and the warning is gone on recent snaps.

jcyr · Feb 18, 2013, 8:21 PM

Yep. I committed the fix. Sorry I made the false assumtion.