Issue with NAT FTP rule.
When testing FTP worked fine for a while then stopped listing directories. Setting "Disable the pf ftp proxy handler." to 1 fixed for a short while then stopped again. Enable and disable seemed to work again for a bit.
Apart from this looking good!
You're not alone: http://forum.pfsense.org/index.php/topic,62237.0.html