Amazing piece of code…

rmssf

shaper.inc:2796


		if ($data['plr'] && ((!is_numeric($data['plr'])) ||
			($data['plr'] <= 0 && $data['plr'] > 1))) 
            		$input_errors[] = "Plr must be an integer between 1 and 100.";
		if (($data['buckets'] && (!is_numeric($data['buckets']))) ||
			($data['buckets'] < 1 && $data['buckets'] > 100)) 
            		$input_errors[] = "Buckets must be an integer between 16 and 65535.";

eri--

That's the power of copy/pasto no :)
I fixed the descriptions.

Klaws

I vaguely remember that "buckets" is the size of the TBR in bytes, and that the maximum value is 65535.

Has this been changed?

phil.davis

Yes, Ermal fixed up the numbers in the tests and the text messages to match each other (I can't remember which were wrong and which were right - but it is in a commit some time ago.)

marcelloc

Does it will match any time?
($data['plr'] <= 0 && $data['plr'] > 1)
($data['buckets'] < 1 && $data['buckets'] > 100)

How can a value can be smaller then 0 and higher then 1 at the same time? ???

eri--

It was wrong mareclloc :)