Navigation

    Netgate Discussion Forum
    • Register
    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search

    System Patches - auto-apply patch does not work…

    pfSense Packages
    2
    6
    2790
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • D
      doktornotor Banned last edited by

      The auto-apply patch option has no effect whatsoever here with 2.1-RC0 snapshots. Nothing applied after firmware snapshots upgrade and repeated reboots. Always need to reapply the patch manually. Does this actually work for anyone?  ???

      1 Reply Last reply Reply Quote 0
      • jimp
        jimp Rebel Alliance Developer Netgate last edited by

        NanoBSD or a full install?

        Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

        Need help fast? Netgate Global Support!

        Do not Chat/PM for help!

        1 Reply Last reply Reply Quote 0
        • D
          doktornotor Banned last edited by

          Nano… usually on (almost) latest snapshot. :)

          1 Reply Last reply Reply Quote 0
          • jimp
            jimp Rebel Alliance Developer Netgate last edited by

            If you revert a patch, set it to auto-apply, and then reboot, does it work then?

            Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

            Need help fast? Netgate Global Support!

            Do not Chat/PM for help!

            1 Reply Last reply Reply Quote 0
            • D
              doktornotor Banned last edited by

              Well… no, that did not help. But - I guess I figured it out. It seems like the patch confuses the hell out of the thing, since it can be both applied and "reverted" with both actions being always "clean", just the offset is growing by 1 line... Can you try with this one to see if you can reproduce it?

              
              --- /etc/inc/system.inc	2013-06-23 08:14:58.000000000 +0400
              +++ /etc/inc/system.inc	2013-06-23 08:14:58.000000000 +0400
              @@ -1501,7 +1501,6 @@
               function enable_watchdog() {
               	global $config;
              -	return;
               	$install_watchdog = false;
               	$supported_watchdogs = array("Geode");
               	$file = file_get_contents("/var/log/dmesg.boot");
              
              

              (being basically a revert of the first hunk of commit 1a479479f397973257592f32c5c7adc8cd088a82).

              Cf. this logic:

              
              /* If the patch can be reverted it is already applied, so skip it. */
              		if (!patch_test_revert($patch)) {
              			/* Only attempt to apply if it can be applied. */
              			if (patch_test_apply($patch)) {
              				patch_apply($patch);
              			}
              
              
              1 Reply Last reply Reply Quote 0
              • jimp
                jimp Rebel Alliance Developer Netgate last edited by

                I never could reproduce this. It always applied at boot for me post-upgrade.

                That said, given the problem you hit with another issue, I tried delcaring the variables global before defining them in the patches package include file. Upgrade the package, and then see if it works after the next firmware update.

                Remember: Upvote with the 👍 button for any user/post you find to be helpful, informative, or deserving of recognition!

                Need help fast? Netgate Global Support!

                Do not Chat/PM for help!

                1 Reply Last reply Reply Quote 0
                • First post
                  Last post