Mbuf RRD graphs

[wallabybob]

I'm running

2.1-RC0 (i386)
built on Sun Jul 21 09:48:24 EDT 2013
FreeBSD 8.3-RELEASE-p8

The system log reports

Aug  1 19:34:09 pfsense2 php: rc.bootup: The command '/usr/bin/nice -n20 /usr/local/bin/rrdtool update /var/db/rrd/system-mbuf.rrd N:U:U:U:U:U' returned exit code '1', the output was 'ERROR: expected 4 data source readings (got 5) from N:U:U:U:U:U'

Looking through /etc/inc/rrd.inc, perhaps```
                        mwexec("$rrdtool update $rrddbpath$ifname$mbuf N:U:U:U:U:U");

In file /var/db/rrd/updaterrd.sh I notice the mbuf RRD file holds mbuf cluster data. The corresponding graph is selected by "Mbuf". This is misleading because mbufs are not the same as mbuf clusters. Both are important for networking.

I think the optimum solution is probably to record data for BOTH mbufs and mbuf clusters and use the correct label for selection of the appropriate graph. Having opened up the discussion about the mbuf graphs, I think it would also be useful to record the corresponding allocation denials but since this number can increase indefinitely its not immediately clear to me what form of it to use to avoid distorting the graphs. Even "denials in the last minute" could be a large number.

At the least, the existing mbuf graphs should be selected by "Mbuf clusters" rather than "Mbufs".

In the interest of ease of ongoing software maintenance the name of the file holding mbuf clusters data should be changed o reflect the fact it holds mbuf clusters data rather than mbufs data, for example from system-mbuf.rrd to system-mbuf-cl.rrd.

[ptt]

You are late  ;D  (at least about the "error" message part)

http://forum.pfsense.org/index.php/topic,64558.msg352036.html#new