Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Added Disable HTTPS Forwards to Captive Portal / Github n00b

    Scheduled Pinned Locked Moved Development
    2 Posts 1 Posters 1.4k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • DerelictD Offline
      Derelict LAYER 8 Netgate
      last edited by

      I am a total github n00b.  I added a feature some might be interested in.  It allows one to use SSL login pages in captive portal but disable the forwards of connections to port 443 to the CP.

      https://github.com/derelict-pf/pfsense/commit/c19339b453e07afd11e8d795e7519ac5c6592667

      I have no idea if that is the proper format nor how to view changes in relation to RELENG_2_1.

      I did the following:

      Forked pfsense on github

      $ git clone https://github.com/derelict-pf/pfsense.git
      $ cd pfsense
      $ git remote add upstream https://github.com/pfsense/pfsense.git
      $ git fetch upstream
      From https://github.com/pfsense/pfsense

      • [new branch]      RELENG_1_2 -> upstream/RELENG_1_2
      • [new branch]      RELENG_2_0 -> upstream/RELENG_2_0
      • [new branch]      RELENG_2_1 -> upstream/RELENG_2_1
      • [new branch]      master    -> upstream/master
        $ git branch nohttpsforwards
        Edit etc/inc/captiveportal.inc
        Edit usr/local/www/services_captiveportal.php
        $ git commit -a

      Chattanooga, Tennessee, USA
      A comprehensive network diagram is worth 10,000 words and 15 conference calls.
      DO NOT set a source address/port in a port forward or firewall rule unless you KNOW you need it!
      Do Not Chat For Help! NO_WAN_EGRESS(TM)

      1 Reply Last reply Reply Quote 0
      • DerelictD Offline
        Derelict LAYER 8 Netgate
        last edited by

        I am going to figure out git before I go any further.  The link above is dead because I'm going to delete my repository and start over.

        Chattanooga, Tennessee, USA
        A comprehensive network diagram is worth 10,000 words and 15 conference calls.
        DO NOT set a source address/port in a port forward or firewall rule unless you KNOW you need it!
        Do Not Chat For Help! NO_WAN_EGRESS(TM)

        1 Reply Last reply Reply Quote 0
        • First post
          Last post
        Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.