2.1.2 Update: editing broken?


  • Rebel Alliance Moderator

    After the update to 2.1.2 (from 2.1.1) and editing aliases, nat rules or firewall rules, I get:

    Fatal error: Cannot redeclare crypt_data() (previously declared in /etc/inc/crypt.inc:35) in /etc/inc/crypt_acb.php on line 43
    

    That worked fine on 2.1.1 as I edited various rules and aliases over the day. It is broken since the update about 15min ago.

    Any thoughts?


  • Rebel Alliance Moderator

    Added information:

    In my case it happens on almost EVERY save dialogue. Including ha-sync or even system/advanced menu. Always the same crypt_data error.

    In addition I get this on every save-try:

    php: rc.filter_synchronize: New alert found: An error code was received while attempting XMLRPC sync with username admin https://192.168.168.2:443 - Code 2: Invalid return payload: enable debugging to examine incoming payload
    

    The config is synced as much as I can see (a newly created alias with the same save-bug was synced to the second node), but I get these errors nonetheless and now am highly worrying about the sanity of my cluster.


  • Banned

    Sounds like autoconfigbackup package.


  • Rebel Alliance Developer Netgate

    Update the autoconfigbackup package to 1.22.

    If you can't, first do this and then update the package:

    rm /etc/inc/crypt_acb.inc /usr/local/pkg/autoconfigbackup*
    

    Might reboot for good measure.


  • Rebel Alliance Moderator

    Thanks everybody. To those, that may encounter the same problem:

    After upgrading to 2.1.2 (coming from 2.1.1) the packages weren't updated or reinstalled (as I assumed wrong) and so autoconfbackup 1.21 still was running and effectively breaking the whole freakin' UI. Every save, delete or other config-safe-related button was broken.

    So after removing it (package removal didn't work as the textarea containing the status stayed empty and nothing was processing) with brute force (like jimp suggested by removing the pkg dir) and reinstalling it, everything is back to normal again.

    Note to self: don't upgrade the cluster remotely to safe working-time. Gets your pulse-rate up ;)

    Thanks to all and greets to the team for quick and great work so far!
    Jens



  • That does sound a bit worrysome that the main pfsense image depends on a package being updated first (during an upgrade of course).  If someone does not update autoconfigbackup again when/if the next release is out could they have the same issue?

    EDIT: Oh… never mind... I think the version check was for the autoconfigbackup package version which just forgot to get bumped in that one spot.  I don't think the main pfsense package version check would be an issue for the future.  I am just guessing though as I don't really understand the code :).



  • Note the "rm" should be:

    rm /etc/inc/crypt_acb.php
    rm /usr/local/pkg/autoconfigbackup*
    

    (JimPs post had .inc and should have been .php)
    The post in the other thread about this has the correct crypt_acb.php file name.
    I'm sure JimP will quickly modify his post, then I can delete this.



  • @adam65535:

    That does sound a bit worrysome that the main pfsense image depends on a package being updated first (during an upgrade of course).  If someone does not update autoconfigbackup again when/if the next release is out could they have the same issue?

    It was just a dumb bug in AutoConfigBackup that tested for "1.2" anywhere in the version string, which now matches "2.1.2". It only effected people who use AutoConfigBackup (hey, that's the paying customers) and JimP fixed it in 5 minutes after it was reported.
    From now, people who upgrade will get the correct AutoConfigBackup files installed and will never see this issue.



  • Thanks for the info.  After looking at the commit in github I figured that as much and it looks like I edited my post the same time you posted your info.  Thanks for the clarification.



  • @jimp:

    Update the autoconfigbackup package to 1.22.

    If you can't, first do this and then update the package:

    rm /etc/inc/crypt_acb.inc and /usr/local/pkg/autoconfigbackup*
    

    Might reboot for good measure.

    @phil.davis:

    Note the "rm" should be:

    rm /etc/inc/crypt_acb.php
    rm /usr/local/pkg/autoconfigbackup*
    

    (JimPs post had .inc and should have been .php)
    The post in the other thread about this has the correct crypt_acb.php file name.
    I'm sure JimP will quickly modify his post, then I can delete this.

    Doh!  I just deleted my custom 'and' file that was in my directory! ;)



  • And I thought this was something from the Australian Cricket Board.



  • I have a similar issue where my packages weren't installed. And of course I can't remember which packages I had. Is there a way to restart the upgrade process and get packages in?


Log in to reply