Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    Pppoe server units

    Scheduled Pinned Locked Moved General pfSense Questions
    23 Posts 2 Posters 13.2k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • S
      sullrich
      last edited by

      We dont need to calculate that value since its calculated from the subnet mask that the person chooses.

      I fixed all the other issues but I still havent seen anything reported on how it works.

      1 Reply Last reply Reply Quote 0
      • A
        aldo
        last edited by

        will checkout the changes you have made and try again.
        my understanding of part of the issue was here.

        • if (($_POST['pppoe_subnet'] && !is_ipaddr($_POST['remoteip']))) {
          $input_errors[] = "A valid remote start address must be specified.";

        and here

        Subnet netmask

        • <select id="n_pppoe_units" name="n_pppoe_units">+    </select>
                  for($x=0; $x<33; $x++) {
        • if($x == $pconfig['n_pppoe_units'])
        • if($x == $pconfig['pppoe_units'])
          $SELECTED = " SELECTED";
          else
          $SELECTED = "";

        when you ask in the web gui for subnet mask you put this value into pppoe units. i did not see this changed. so my diff fixes this add adds pppoe units in. I saw that n_pppoe_units seems to be auto calculated in your recent commit but i dont think you dealt with this part of the problem.

        1 Reply Last reply Reply Quote 0
        • A
          aldo
          last edited by

          the vpn_consilidation seems to stop the replication of the configuration.

          I just noticed a small error in my previous post but i think you will understand me.
          If you like i will rediff it with just the subnetmask fix that seems to be required.

          1 Reply Last reply Reply Quote 0
          • S
            sullrich
            last edited by

            Yes you are correct.  This appears to be anothe rproblem.  I'll check into this but would appreciate you checking the rest of my changes out.

            1 Reply Last reply Reply Quote 0
            • S
              sullrich
              last edited by

              @aldo:

              the vpn_consilidation seems to stop the replication of the configuration.

              I just noticed a small error in my previous post but i think you will understand me.
              If you like i will rediff it with just the subnetmask fix that seems to be required.

              Go for it.

              1 Reply Last reply Reply Quote 0
              • A
                aldo
                last edited by

                pppoe replication of config file only seems to occur at boot time now.
                each time pfsense is rebooted it adds the config to the bottom of the exsisting file.

                maybe the contents of /var/etc/mpd-vpn should be removed on each reboot.

                1 Reply Last reply Reply Quote 0
                • A
                  aldo
                  last edited by

                  just noticed the aliases for ptpp and pppoe in pf
                  seem to be allocated like so ptpp ng0 to 16
                  pppoe ng 17 to 31. this seems to be based on the default values
                  that are hardcoded for these. so even if ptpp if off
                  it will stilll have ng0 to ng16 allocated to it.

                  other changes seem fine.

                  the pppoe_subnet issue seems to be a little more difficult.
                  I know you dont like my patch but it works right. In respect
                  to the subnet and the n_pppoe_units setting is that it should
                  be possible to have a subnet of /24 but have a unit setting
                  of anything up to 254. The example would be multiple NAS devices
                  and one IPpool. You might set each Nas with the same /24 and
                  allocate Ip's from one radius pool. also you might have a subnet
                  of /24 with internal allocations but only activate 25 units.
                  but in three months add 30 more units cos you have more clients.

                  just thoughts i know how you feel about this staying hardcoded.
                  but it looks easier if it was not.

                  1 Reply Last reply Reply Quote 0
                  • S
                    sullrich
                    last edited by

                    @aldo:

                    just noticed the aliases for ptpp and pppoe in pf
                    seem to be allocated like so ptpp ng0 to 16
                    pppoe ng 17 to 31. this seems to be based on the default values
                    that are hardcoded for these. so even if ptpp if off
                    it will stilll have ng0 to ng16 allocated to it.

                    Okay, this should be fixed now.

                    @aldo:

                    other changes seem fine.

                    the pppoe_subnet issue seems to be a little more difficult.
                    I know you dont like my patch but it works right. In respect
                    to the subnet and the n_pppoe_units setting is that it should
                    be possible to have a subnet of /24 but have a unit setting
                    of anything up to 254. The example would be multiple NAS devices
                    and one IPpool. You might set each Nas with the same /24 and
                    allocate Ip's from one radius pool. also you might have a subnet
                    of /24 with internal allocations but only activate 25 units.
                    but in three months add 30 more units cos you have more clients.

                    just thoughts i know how you feel about this staying hardcoded.
                    but it looks easier if it was not.

                    I was waiting on an updated patchset :)

                    1 Reply Last reply Reply Quote 0
                    • A
                      aldo
                      last edited by

                      sorry scott just an update i have one patch done but not 100% happy have been busy working on a large project and tinkering with quagga on pfsense which has been going well. will have a better one for you by the end of the weekend

                      1 Reply Last reply Reply Quote 0
                      • S
                        sullrich
                        last edited by

                        Okay, no problem-o.

                        1 Reply Last reply Reply Quote 0
                        • S
                          sullrich
                          last edited by

                          PPPoE is fully working now.

                          Please cvs_sync.sh releneng_1 and test!

                          Tested so far:

                          • Port forwards

                          • Firewall rules

                          • Radius

                          1 Reply Last reply Reply Quote 0
                          • First post
                            Last post
                          Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.