PfBlocker Widget XHTML Errors

NOYB · Apr 13, 2014, 4:07 AM

The pfSense dashboard pfBlocker widget has at least 30 XHTML document errors. The Firewall pfBlocker configuration pages also have lots of XHTML document errors.

pfSense 2.1.2 dashboard with System Information, Interfaces, Gateways, Services Status, and Firewall Logs widgets is clean.

Include the pfBlocker widget in the dashboard and hoards of XHTML document errors are revealed.

http://validator.w3.org/

Line 1537, Column 14: ID "pfBlocker" already defined
Line 1536, Column 16: ID "pfBlocker" first defined here
Line 1538, Column 18: unclosed start-tag
Line 1538, Column 26: document type does not allow element "pre" here; missing one of "th", "td" start-tag
Line 1538, Column 45: document type does not allow element "td" here
Line 1538, Column 91: document type does not allow element "td" here
Line 1538, Column 137: document type does not allow element "td" here
Line 1538, Column 185: document type does not allow element "td" here
Line 1538, Column 218: end tag for "pre" omitted, but OMITTAG NO was specified
Line 1538, Column 22: start tag was here
Line 1538, Column 218: end tag for "tr" which is not finished
Line 1538, Column 237: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 395: required attribute "alt" not specified
Line 1538, Column 400: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 330: start tag was here
Line 1538, Column 424: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 581: required attribute "alt" not specified
Line 1538, Column 586: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 610: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 769: required attribute "alt" not specified
Line 1538, Column 774: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 704: start tag was here
Line 1538, Column 798: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 962: required attribute "alt" not specified
Line 1538, Column 967: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 897: start tag was here
Line 1538, Column 991: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 1151: required attribute "alt" not specified
Line 1538, Column 1156: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 1086: start tag was here
Line 1538, Column 1180: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 1344: required attribute "alt" not specified
Line 1538, Column 1349: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 1279: start tag was here
Line 1538, Column 1373: document type does not allow element "td" here; assuming missing "tr" start-tag
Line 1538, Column 1537: required attribute "alt" not specified
Line 1538, Column 1542: end tag for "img" omitted, but OMITTAG NO was specified
Line 1538, Column 1472: start tag was here
Line 1538, Column 1554: end tag for element "tr" which is not open

doktornotor · Apr 13, 2014, 9:28 AM

Honestly?

pfBlocker needs a severe diet, getting rid of useless stuff such as the GeoIP-based lists years and years old and completely useless
the legacy HTML tables layout needs to get eradicated everywhere across the pfSense code
these "validator" fixes caused a bunch of severe regressions (such as completely breaking the schedules) lately so IMNSHO this just should be left as it is as long it works