Netgate Discussion Forum
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Search
    • Register
    • Login

    How to submit a patch (adding ovh.com DDNS service) ?

    Scheduled Pinned Locked Moved Development
    4 Posts 3 Posters 1.1k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • M
      m3z
      last edited by

      Hello,

      I add support of OVH.com DDNS service.
      How can i submit a patch to dev team ?

      What is the process to validate update ?
      Can i push my update directly on the master branch of the pfsense Git server ? (probably not ;) )

      Thanks in advance

      1 Reply Last reply Reply Quote 0
      • P
        phil.davis
        last edited by

        Make a GitHub account, attempt to edit the file on GitHub pfSense. It will make a new fork and branch in that fork for you. Save your edits, hit the "Pull Request" button.
        Then the devs will see the Pull Request to master and review it and (hopefully) commit it.
        Note that 2.1.n series is really in "essential maintenance" mode now - critical fixes only are likely to cause another 2.1.n release. Your enhancements will get applied to master, and likely not be back-ported to 2.1 branch. So they would appear in 2.2 release.

        As the Greek philosopher Isosceles used to say, "There are 3 sides to every triangle."
        If I helped you, then help someone else - buy someone a gift from the INF catalog http://secure.inf.org/gifts/usd/

        1 Reply Last reply Reply Quote 0
        • M
          m3z
          last edited by

          Thanks for your help.

          It's a very little update , it can wait for next release without problem.

          Thanks again.

          1 Reply Last reply Reply Quote 0
          • DerelictD
            Derelict LAYER 8 Netgate
            last edited by

            Can anyone help me with the process to apply patches to different branches?

            I want to submit an enhancement I've written and tested against 2.1.2 but it needs to be submitted as a pull to master?

            I've forked on github and am working with a local clone with these upstreams and origins:

            [core]
            repositoryformatversion = 0
            filemode = true
            bare = false
            logallrefupdates = true
            ignorecase = true
            precomposeunicode = false
            [remote "origin"]
            url = https://github.com/derelict-pf/pfsense.git
            fetch = +refs/heads/:refs/remotes/origin/
            [branch "master"]
            remote = origin
            merge = refs/heads/master
            [remote "upstream"]
            url = https://github.com/pfsense/pfsense.git
            fetch = +refs/heads/:refs/remotes/upstream/

            If I want to make and test my changes against 2.1.2, do I checkout origin/RELENG_2_1 (or upstream/RELENG_2_1 ??), then create a feature branch there and somehow get just those changes back to master for submission as a pull request?

            Or do I checkout master, create a feature branch there, make my changes and somehow apply them to RELENG_2_1 for testing?

            Thanks for any guidance that can be provided.  Creating the simple feature has been much easier than getting me head wrapped around git.

            I also want to use git to manage changes I make to files that get whacked when I upgrade, such as /usr/local/captiveportal/index.php, with the goal of making it easier to reapply my changes to the new version.

            Chattanooga, Tennessee, USA
            A comprehensive network diagram is worth 10,000 words and 15 conference calls.
            DO NOT set a source address/port in a port forward or firewall rule unless you KNOW you need it!
            Do Not Chat For Help! NO_WAN_EGRESS(TM)

            1 Reply Last reply Reply Quote 0
            • First post
              Last post
            Copyright 2025 Rubicon Communications LLC (Netgate). All rights reserved.