How to propose patches to pfsense-tools? (a.k.a. pull requests)

msi

Hi

So it seems most commits made to pfsense-tools have been made by ESF crew lately, master seems to be what is becoming 2.2 whereas RELENG_2_1 is for 2.1 - right?

While on github we have the pull request mechanism I haven't tried direct pushing (I wouldn't dare to break builds this way).
So here is my question: What is the way to contribute to pfsense-tools - or do we have to pass through redmine as jeremy mentioned in the first post on the -tools repo?

jimp

We're still trying to work out the best way for that to happen. At the moment, submitting patches to the dev list or via redmine is probably the best course of action.

The accounts given for accessing the tools repo can't push, and even if they could, they don't connect to the primary repository but a mirrored copy for 'public' access. It's identical, but it's not where the builds pull the code from. Similar to how the pfSense repo on github is mirrored from the same internal source.

msi

OK, I tried redmine, I guess it's yet to be found what works and what is accepted.

As little side-note: Just short time after my question, the BSD now! podcast mentioned FreeBSD testing Phabricator (https://wiki.freebsd.org/CodeReview) - however I don't know if that's of interest for pfSense.

robi

So no more GitHub pushes?

razzfazz

Given that pfsense-tools is no longer available on GitHub, I would think not.

robi

Why not? Fixes to the web interface don't need any tools…

msi

We're only speaking about the pfsense-tools repository which is what is required to fully build and test stuff.
For web-facing changes or packages, -tools is not required - it also contains Kernel/OS patches as well as some patched ports that need some extra mangling before they can be taken from FreeBSD ports to pfSense.

For all other repositories (as on github.com/pfsense):
Pull requests over Github seem to continue as is (except for the CLA requirement)

Guest

@MatSim:

For all other repositories (as on github.com/pfsense):
Pull requests over Github seem to continue as is (except for the CLA requirement)

Which exists to protect the project