Gold Menu Item Knocking Help Menu Item to Next Line

asayler

See attached screenshot.

It's been this way since at least last week's Sat Aug 23 02:30:11 CDT 2014 build and remains this way in tonight's Sat Aug 30 11:37:28 CDT 2014 build.

In addition to being visually problematic, it completely breaks the "System" dropdown that now resides above Help, since any attempt to use the System dropdown just triggers the help dropdown instead.

I've tested it in both Chrome 37.0.2062.94 (64-bit) and Firefox 31.0, both running on Ubuntu 14.04. I use 1920x1080 monitors and the browsers full screened.

Using the Chrome developer console to delete the new Gold menu item restores the Help menu to its proper location.

As helpful as the new Gold menu dropdown is ::), I'd much rather have a properly placed "Help" dropdown and working System dropdown. Currently I'm forced to open a development console and delete the Gold* node on the fly just to access System menu items… :o

The issue appears on both the pfsense_ng and pfsense_ng_fs (widescreen) themes. I have not tested it on other themes.
![PFSenseHelpIssue.png](/public/_imported_attachments_/1/PFSenseHelpIssue.png)
![PFSenseHelpIssue.png_thumb](/public/_imported_attachments_/1/PFSenseHelpIssue.png_thumb)

asayler

Looks like this has already been reported on Redmine: https://redmine.pfsense.org/issues/3841.

Should have checked there first…

asayler

And clearing the cache, restarting the browser, etc has no effect on the issue in either Chrome or Firefox.

jdillard

I just committed some fixes, let me know if they work. I think the fix for pfsense_ng and pfsense_ng_fs already made it into the latest snapshot.

kejianshi

I suspected that will come quickly. I suppose a minor update will be released as a push button auto upgrade soon?
My system is not very affected by all this. I can wait that.

asayler

The Wed Sep 03 16:56:44 CDT 2014 2.2 Alpha snapshot seems to work fine for the pf_sense_ng_fs theme. It did require soem refreshing/cache clearing, but all teh menu items seem to comfortably fit on one line again. Thanks!

jdillard

@kejianshi:

I suspected that will come quickly. I suppose a minor update will be released as a push button auto upgrade soon?
My system is not very affected by all this. I can wait that.

Ultimately not my call, but I doubt it just for this. If a security fix comes up I'm sure the fix will be cherry picked into it. You can make the changes in the commit manually using the shell, scp the file over, or use a vertical nav theme for the time being.

https://github.com/pfsense/pfsense/commit/6817c18afa737e83756516a7b7c14ff5e5d85814

@asayler:

The Wed Sep 03 16:56:44 CDT 2014 2.2 Alpha snapshot seems to work fine for the pf_sense_ng_fs theme. It did require soem refreshing/cache clearing, but all teh menu items seem to comfortably fit on one line again. Thanks!

Great! Thanks for taking a look. I'll work in URL fingerprinting for things like CSS so a browser refresh isn't required after each upgrade (if changes are made).

stephenw10

I assume that since that commit was against master it can't be applied via system patches in 2.1.5?
Be nice if a similar commit against RELENG_2_1 existed. ;)

Steve

charlie0440

Just for your stephen…

This should work for pfsense_ng

https://github.com/CharlieMarshall/pfsense/commit/f216a5824fdc12c6b13cd950cc4625445093fe28

For the other themes there were conflicts! So not sure what the result will be, maybe some wierd spacing. But if you want to try those too:

https://github.com/CharlieMarshall/pfsense/commit/524773cf9adbfbf023a4fac8edc49598df27b7ee

stephenw10

Thanks Charlie. :)
I'm not actually seeing the problem (I don't have any MS fonts) so I can't tell if this is working. I just thought that a patch you can use with the system patches package would be a convenient workaround for many.

Steve

Fegu

A simple Ctrl+F5 (i.e. refresh of page + dependencies such as CSS) fixed this issue for me. No patches necessary.