[FIXED] 7th jan php errors
-
nanobsd alix
php-fpm[16262]: /rc.newipsecdns: PHP ERROR: Type: 8192, File: /etc/inc/shaper.inc, Line: 4365, Message: Assigning the return value of new by reference is deprecated -
Pull request https://github.com/pfsense/pfsense/pull/1426
should fix this "deprecated" warning in all the places in the code where this style of code was. And also fixes a bunch of other messages I got when I turned on RSS widget, which uses simplepie.inc -
i guess that patch messed up a lot of the things, i installed the update with the patch and after a reboot lost complete internet access, limiter shows wrong or repeated entries and few other things that got affected so i switched to the older slice and rebooted and was back in business
could be the snapshot might be buggy but i think patch might be the cause
-
Yeah that set of changes broke some things. I reverted it. We can revisit that at some point post-2.2, the errors it was fixing aren't a problem (and their logging has since been disabled).
-
it would be better to delete those snaps as they end up in a dead system
-
Only for those using limiters, which is a small minority. If it were completely broken, I'd delete it. New snapshots are building now so it'll be replaced in the next hour or so.
-
My apologies to all concerned. I thought all those warning messages had quite simple generic code changes, and did a bit of testing of functions, but did not notice closely enough the difference in the returned array from read_dummynet_config(), for example. Obviously I was wrong about the changes being invisible to the callers!
-
new snaps with it reverted work fine
-
My apologies to all concerned. I thought all those warning messages had quite simple generic code changes, and did a bit of testing of functions, but did not notice closely enough the difference in the returned array from read_dummynet_config(), for example. Obviously I was wrong about the changes being invisible to the callers!
It happens, I overlooked it as well.