GUI reports errors when modifying DHCP static leases when upg 2.2.1 to 2.2.2

epimeteo

Definitly NOT a "low risk" upgrade, as usual. Very VERY annoying specially for a mantain release.

First problem is the COM1 must be disabled from BIOS. Not a problem IF THE BOX IS NEAR YOU…

Second and bigger. When I try to add a new DHCP fixed lease the GUI crashes witch this message:

Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 239 Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 239 Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 239 Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 239 Warning: in_array() expects parameter 2 to be array, null giv

Third (and it seems very strange - i need to test more to be sure of the behaviour): I try to delete a DHCP lease but it magically appears again after a logout / login in the GUI without IP. And now it is impossible to remove from leases. (even if there is no MAC responding) check the picture.

leaseDHCP.jpg_thumb

phil.davis

Warning: in_array() expects parameter 2 to be array, null given in /etc/inc/unbound.inc on line 239

Apologies for number 2. It turns out it is just a warning, looks very messy on the GUI but underneath the unbound configuration is built correctly. The warning appears if you have Unbound Forwarding mode on, and "Allow DNS server list to be overridden by DHCP/PPP on WAN" is off.
Fixed by this pull request: https://github.com/pfsense/pfsense/pull/1615

andrewCIT

I had the same error as the OP after upgrading from 2.2.1 to 2.2.2 and the above commit does indeed correct the issue.

Thanks Phil!