[SOLVED] Firewall Log Dynamic does not update

[phil.davis]

There is no "dynamic" to Firewall Log Dynamic view.
diag_logs_filter_dynamic.php refers to /javascript/filter_log.js
But master branch no longer has a "javascript" folder. I can't see filter_log.js anywhere in master. This seems to remove any hope of the various bits of PHP and JavaScript working together to provide dynamic updates.

This makes it hard to test other stuff about the dynamic view and dynamically updated rows, because I can't get any dynamic update to happen at all.

[Steve_B]

Dynamism has been restored.

etc/inc/filter_log.inc has been updated to use fa icon, but still needs work similar to you recent PR

[phil.davis]

https://github.com/pfsense/pfsense/pull/2019 to get the icon cross/tick and the popup rule display working.
I also made a couple of other PRs to minimize some code duplication in other diag_log_filter* when selecting the block/pass icons to use.

[Steve_B]

PRs tested and merged. I made a small change after merging to support moving the action icon to the left of the dynamic page. Everything seems to work very nicely now.

Thanks again for the help.